Keep looking inside project about kondo HOT 5 OPEN

I run into that even on this project :) the kondo-ui subdirectory is not part of the workspace so it has it's own target directory, which is skipped because it's inside a project.

The code causing this is here

Perhaps this decision should be on a project type basis.

from kondo.

Or a project type basis. With node_modules you either want to delete the whole tree, including transient dependencies, or you want to keep all of it.
But with Rust target, the other targets are not under the top target. In fact both specifically examples and any other workspace/non-workspace nested projects are whole projects, precisely because they are source projects and not just published dependencies.
So, should it ask for each nested project, or just once for the topmost project and apply that ruling to all nested projects? 🤔

Also sometimes you have node_modules in Rust projects and Rust target in npm module projects...

from kondo.

That's a good point, I hadn't considered directories that are more than one type of project, eg cargo and node project. Hmm... I'll have to think on that, also how to recurse directories that are not artifacts of the current project, the implementation now might make that a little tricky.

from kondo.

Still, at least looking at just Rust and nodejs, it seems like differentiating between:

• artifact directories (delete, never enter)
• literally everything else (don't delete, recurse)

should be sufficient?

So:

1. get directory listing (actually collect to memory), while looking for marker files that signify a project. You can actually collect into two Vecs by DirEntry::file_type() which unlike metadata() is said not to involve additional syscalls.
2. look through directory listing, looking for marker files and immediately mark the corresponding artifacts for "deletion".
3. recurse on directories that have not been marked.

from kondo.

That makes sense. I'll think through it. I think this might also be a good opportunity to add integration tests for the project, and model these situations.

from kondo.