Git Product home page Git Product logo

Comments (5)

ahume avatar ahume commented on May 28, 2024 1

Yes, the GCLB add-on for Google Container Engine. I was thinking env vars for the controller. As you say, within a single cluster I imagine the mechanisms for SSL termination being consistent. I've a code change that implements this which I'll push to a fork later today for you to look at.

I'd suggest going down the path of trying to match the expected file names for different ingress implementations inside the letsencrypt-controller could get unwieldy, and somewhat couples what are independent components.

from kubernetes-letsencrypt.

ahume avatar ahume commented on May 28, 2024

I was thinking of implementing this by allowing environment variables to override the default names. Meaning it could be backwards compatible prior to v2.0. How do you feel about that approach?

from kubernetes-letsencrypt.

tazjin avatar tazjin commented on May 28, 2024

@ahume Is your use-case also Ingress controllers? I've been considering to just let it create files with both the current names and the Ingress-specific ones (storage is cheap!).

Were you thinking about envvars on controller level (i.e. affecting all secrets created by the controller)? It's also possible on annotation-level but would probably get very verbose and I suppose most people have a somewhat uniform infrastructure.

from kubernetes-letsencrypt.

tazjin avatar tazjin commented on May 28, 2024

Sounds good to me. I'll change this issue to the next release milestone instead.

Looking forward to your PR!

from kubernetes-letsencrypt.

tazjin avatar tazjin commented on May 28, 2024

Released as v1.4!

from kubernetes-letsencrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.