Git Product home page Git Product logo

Comments (2)

taylorhakes avatar taylorhakes commented on June 19, 2024

Yes, prototype methods are visible to the outside world, essentially public. It is common pattern to put private methods on prototype, but prefix with an underscore. i.e. Promise.prototype._privateFunc.

Since this library is a polyfill, I tried to make it as close to the built-in Promise as possible. The built-in Promise doesn't expose any underscore methods.

You can make true private methods using a closure and calling it like fn.apply(this, args). You still get the same performance benefits as the prototype methods, but the functions are not exposed to the outside world on the prototype. Does that make sense?

from promise-polyfill.

DarkPark avatar DarkPark commented on June 19, 2024

thank you for detailed explanation
I haven't check the native Prototype global object to see the same public methods
so now it's clear

from promise-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.