Comments (18)
Hey @ToddMurphy92 ,
The issue does exist. Like I said before, I think it has something to do with using the 'site.github' name for the variable. Try renaming the variable to something else and replacing it wherever it is being used in the theme. At least that's how I fixed it.
@libeclipse Did you actually try removing the github button? This issue only occurs with the github button and not the others.
PS: Don't know why the creator hasn't resolved it yet.
from moon.
@ToddMurphy92 Aah okay. I don't really have it on my system to give it a go. But in case you would like to quickly try, I think you need to 'mainly' change it here (after changing it in the _config.yml) : https://github.com/ToddMurphy92/ToddMurphy92.github.io/blob/master/_includes/social-links.html
from moon.
You've probably accidentally changed some file but I cannot really check since it doesn't seem to be on your website.
from moon.
Well, I did consider that. So, I forked a new version and just commented the line with respect to the github link. And still the problem persists.
Then I resolved the issue by renaming the 'site.github' variable to something else. And it worked.
I think it might have something to do with this: https://help.github.com/articles/repository-metadata-on-github-pages/
from moon.
PS: My website isn't using this theme anymore.
from moon.
Please close this issue then if it's no longer relevant.
from moon.
Don't you think it is still relevant as the issue isn't actually resolved?
I did find a workaround but the issue still exists in the theme itself.
from moon.
I'm not too sure. I myself have never encountered the issue or anything
similar. If you're sure it wasn't an error you made then fair enough.
from moon.
I'm also getting this issue with http://toddmurphy.me/ which is running this theme currently. Only things I have changed is the config and navigation .yml files.
from moon.
In the creators defence you did say you were no longer using the theme, and so there's not much point in fixing something that doesn't impact anyone (or at least not anyone the dev knows of).
Thanks for the update though. I'll give that a shot, I'll let you know how I go (probably horribly, I'm pretty bad when it comes to git and all things coding).
from moon.
So I had a quick look into removing 'site.github' variable/references and decided I'll just leave this as is and see what the dev says if/when they respond. This isn't really urgent for me, my site doesn't get much traffic and on the rare occasion it does it's unlikely to be from anyone who would be interested in seeing git.
from moon.
@ToddMurphy92 Haha.. yeah. I am not trying to attack or something. It's a thin line, I have a workaround but the issue still exists. :P
from moon.
That did indeed 'fix' the issue for the main page. Still shows up in the about bar though.
from moon.
Modified nav.html, fixed the about bar issue :)
from moon.
Yay! Guess, you know now what to do!
PS: I was about to give you a hint. xD
from moon.
Actually yeah I never tried to remove the github button.
As for @TaylanTatli, he's currently in exam seasons without a PC, so it's unlikely there'll be any fixes any time soon. Might be worth asking for commit rights.
from moon.
Hey, all, the issue does exist. When running this locally using Jekyll, the GitHub button doesn't show if the username is removed. When hosting on GitHub Pages, the button shows, and hovering over the button shows http://github.com/{
.
from moon.
It should be fixed with cd451e3. It was because of Github Metadata.
from moon.
Related Issues (20)
- Accessibility errors found in your template
- Change the logo in navigation HOT 2
- could not load CSS & JS HOT 1
- "Could not find gem 'jekyll-sitemap' in any of the gem sources listed in your Gemfile." HOT 1
- Changing colour of the nav menu and the home hover button HOT 1
- Favicons from head.html not shown
- Image tag doesn't work
- Caption title for images in the popup
- unresponsive page
- Site Map Generation HOT 1
- Background image doesn't show on mobile browser HOT 1
- Missing _site and _plugins folder, can't generate sitemap HOT 1
- How to change the home page icon๏ผ HOT 1
- set images size HOT 1
- Images are not showing
- Share button in post section of Google+
- Post width
- How to change font size?
- Something wrong with highlighting HOT 1
- I always want to enable the comment feature, what should I do?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moon.