Git Product home page Git Product logo

Comments (5)

jiru avatar jiru commented on August 23, 2024

I suggest we make it so that the brackets are not needed in the first place.

from tatoeba2.

alanfgh avatar alanfgh commented on August 23, 2024

Whichever we do, we should make sure that it works the same way in Wall comments and sentence comments. Currently, "[#1]" turns into a link in a sentence comment, but not in a Wall comment.

Also, it would be good to have a way to escape the functionality so that we can print "#1" literally, if desired.

Finally, we should make sure that bare "#1" does not get messed up when it's contained by a URL.

from tatoeba2.

trang avatar trang commented on August 23, 2024

I made the brackets not needed anymore.

from tatoeba2.

jiru avatar jiru commented on August 23, 2024

Correct me if Iā€™m wrong, but now all the existing links with brackets are now showing brackets. That is, previously written [#1234] is now displayed as [#1234]. We should fix the existing messages in the database.

from tatoeba2.

trang avatar trang commented on August 23, 2024

Regarding messages using the old syntax, it's not a critical problem, I think, since the messages that use [#123] instead of just #123 will still generate a link.

I don't think there's anything in mysql to replace \[#(\d+)\] by #$1. You can only replace exact strings, not patterns. It may not really be worth spending time on fixing the database for this.

from tatoeba2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.