Comments (6)
Tundra is not compatible with clojure 1.4.0
Yes, that's correct. Faraday is 1.5+ so Tundra inherits this dependency. For new libs I'm targeting 1.5+. For older libs (like Carmine) I'm targeting a version behind master (so 1.4 until 1.6 is out).
I was trying to remove expectations as a production dependency, but it seems as though all of your libraries have it as well.
Good catch, thanks - I'll clean that up in future updates. Am curious why you're concerned about the extra dependency though?
from carmine.
I think Carmine fails to compile on 1.4 due to the Faraday dependency, do you see otherwise?
The extra dependency isn't a major concern for my work right now, it's largely just pedantry :). That said, the standard set of reasons apply -- more libraries to vet for security, larger uberjars, etc.
from carmine.
Why was this closed? The issue is still occurring; Carmine is not 1.4 compatible as advertised.
from carmine.
Hi, Carmine is compatible with 1.4 - the tests fail because of the inclusion of the Tundra code which is 1.5+. If you don't specifically pull in the Tundra namespace, you shouldn't have any problem running on 1.4.
Does that help?
from carmine.
Yes, thanks. Do you think it is an issue for development if lein with-profile 1.4 test
fails?
Would you be open to splitting the project into a set of libraries? If the Tundra functionality is separate from core functionality and requires a different set of dependencies, I don't think it should be part of the same project. I could say similar things about many of the other features (or anti-features, sometimes).
I really want to get behind all of the work being done here, but every time I want a stripped down Redis client that doesn't surprise me, something happens in Carmine that makes me go berserk.
from carmine.
Do you think it is an issue for development if lein with-profile 1.4 test fails?
You can remove the Farady dependency if you feel better about it, but I would note that it's only in the :test
profile.
Would you be open to splitting the project into a set of libraries?
Not at the moment, sorry - I don't think the removal of a test dependency would warrant the effort. You're of course welcome to strip out anything you're not using: the non-core namespaces (like Tundra) are intentionally kept modular.
something happens in Carmine that makes me go berserk.
Not sure how I can help you with that ;-) As I say, you're welcome to strip out anything you find extraneous. I would keep in mind though that I'm planning to drop official 1.4 support a little while after Clojure 1.6 final is out. Migrating from 1.4 to 1.5 is usually quite painless and brings some real benefits.
Hope that helps, cheers! :-)
from carmine.
Related Issues (20)
- Problems using carmine store HOT 5
- `parse-map` stop working when upgrade from 3.2.0 to 3.3.0 HOT 10
- broken link to nippy in README HOT 1
- Support commands in RediSearch, RedisJSON, RedisTimeSeries, RedisBloom HOT 2
- Handling locked messages after JVM crash HOT 3
- Carmine v4 first core pre-release
- Carmine v4 Tundra
- Carmine v4 Sentinel support
- Carmine v4 Cluster support
- message-queue/queue-names is broken (and untested) HOT 1
- Feedback on v3.3 migration instructions HOT 3
- Silently catches OutOfMemoryErrors without rethrowing HOT 8
- Mutiple atomic transactions as a pipeline HOT 3
- Unexpected behavior with `(parse-map ... :keywordize)` HOT 3
- Does Carmine support DragonflyDB? HOT 10
- Connection loss/failure detection on MQ HOT 12
- Pub/Sub posts to wrong handler fn HOT 5
- Carmine message-queue: allow throughput control HOT 4
- Block on handler being ready when creating new listeners? HOT 4
- Closing the listener produces at least one error message to handler, sometimes several. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carmine.