Git Product home page Git Product logo

Comments (3)

NotAsea avatar NotAsea commented on May 20, 2024 1

Browsing around source code i find your implementation like this

public async Task<int> ExecuteUpdateAsync<TEntity>(
                    Expression<Func<SetPropertyCalls<TEntity>, SetPropertyCalls<TEntity>>> setPropertyCalls,
                    CancellationToken cancellationToken = default)
                    where TEntity : class
{
     int count = await _dbContext.Set<TEntity>().ExecuteUpdateAsync(setPropertyCalls, cancellationToken);
     return count;
}

So instead of calling ExecuteUpdateAsync directly in DbSet, you can change function a little like so

public async Task<int> ExecuteUpdateAsync<TEntity>(
                    Expression<Func<SetPropertyCalls<TEntity>, SetPropertyCalls<TEntity>>> setPropertyCalls,
                    Expression<Func<TEntity, bool>>? predicate = null
                    CancellationToken cancellationToken = default)
                    where TEntity : class
{
    var dbSet = _dbContext.Set<TEntity>();
    if (predicate != null) dbSet = dbSet.Where(predicate);
    return await dbSet.ExecuteUpdateAsync(setPropertyCalls, cancellationToken);
}

Anyway, your library is already good, filter in ExecuteUpdateAsync is some niche thing

from efcore.genericrepository.

TanvirArjel avatar TanvirArjel commented on May 20, 2024

@NotAsea Thank you so much for reaching out. Surely I am taking care of it.

from efcore.genericrepository.

NotAsea avatar NotAsea commented on May 20, 2024

closing as @TanvirArjel has already had planned for it

from efcore.genericrepository.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.