Git Product home page Git Product logo

Comments (9)

lachlancollins avatar lachlancollins commented on August 28, 2024 1

here is a typescript playground with the error.

@lachlancollins can you take a look please? The same code works fine when using useQueries from @tanstack/react-query

Did you mean to ping @ardeora ?

from query.

TkDodo avatar TkDodo commented on August 28, 2024

can you please show a typescript playground? thanks

from query.

TkDodo avatar TkDodo commented on August 28, 2024

closing until we get a typescript playground reproduction

from query.

BierDav avatar BierDav commented on August 28, 2024

Sorry I must have overseen the comment. If you really need a playground I can provide one.

from query.

BierDav avatar BierDav commented on August 28, 2024

Your wish shall be granted: https://codesandbox.io/p/github/BierDav/temp-tanstack-query-ssr-bug/combine-not-working
image
What I want to add additionally is that there is also a bug in executing this code too as you can see on the right hand side of my screenshot:
➜ Network: use --host to expose

TypeError: state.map is not a function
    at file:///project/workspace/node_modules/@tanstack/solid-query/build/dev.js:450:19
    at file:///project/workspace/node_modules/solid-js/dist/server.js:123:12
    at createMemo (file:///project/workspace/node_modules/solid-js/dist/server.js:95:9)
    at Module.createQueries (file:///project/workspace/node_modules/@tanstack/solid-query/build/dev.js:447:25)
    at __vite_ssr_exports__.default (/project/workspace/src/routes/index.tsx?pick=default&pick=$css:15:41)
    at Module.createComponent (file:///project/workspace/node_modules/solid-js/dist/server.js:353:15)
    at Promise.Comp [as resolved] (/project/workspace/node_modules/@solidjs/start/dist/router/lazyRoute.js:35:107)
    at wrap (file:///project/workspace/node_modules/solid-js/dist/server.js:591:30)
    at Module.createComponent (file:///project/workspace/node_modules/solid-js/dist/server.js:353:15)
    at Object.outlet (/project/workspace/node_modules/@solidjs/router/dist/routing.js:450:53)
    at get children [as children] (/project/workspace/node_modules/@solidjs/router/dist/routers/components.jsx:138:23)
    at file:///project/workspace/node_modules/solid-js/dist/server.js:216:35
    at file:///project/workspace/node_modules/solid-js/dist/server.js:179:49
    at createMemo (file:///project/workspace/node_modules/solid-js/dist/server.js:95:9)
    at children (file:///project/workspace/node_modules/solid-js/dist/server.js:179:16)
    at file:///project/workspace/node_modules/solid-js/dist/server.js:216:14
    at createMemo (file:///project/workspace/node_modules/solid-js/dist/server.js:95:9)
    at provider (file:///project/workspace/node_modules/solid-js/dist/server.js:211:12)
    at Module.createComponent (file:///project/workspace/node_modules/solid-js/dist/server.js:353:15)
    at children (/project/workspace/node_modules/@solidjs/router/dist/routers/components.jsx:135:49)
    at Show (file:///project/workspace/node_modules/solid-js/dist/server.js:421:9)
    at Module.createComponent (file:///project/workspace/node_modules/solid-js/dist/server.js:353:15)

Please reopen this issue, if this would work it would really be an outstanding feature

from query.

TkDodo avatar TkDodo commented on August 28, 2024

sorry, is this now a runtime issue (state.map is not a function) or a type level issue as you initially claimed with the screenshot showing "argument of type ... is not assignable to parameter of type ..." ?

from query.

BierDav avatar BierDav commented on August 28, 2024

It is both, but i recommend to resolve the type issue first, maybe this resolves the other one too

from query.

TkDodo avatar TkDodo commented on August 28, 2024

here is a typescript playground with the error.

@lachlancollins can you take a look please? The same code works fine when using useQueries from @tanstack/react-query

from query.

TkDodo avatar TkDodo commented on August 28, 2024

yes, sorry 🙈

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.