Git Product home page Git Product logo

Comments (11)

belgattitude avatar belgattitude commented on June 8, 2024 7

Just landed here from the nextjs issue. Just want to share that personally this kind of comment I saw makes me feel sad. For what it’s worth, with experience and time, I learned that respect and empathy are incredibly important in life.

Not sure if whatever I can say would help, but @TkDodo even if we don’t know each other, I really appreciate the work you’re doing and understand fully your point. Not to create debate, we’re all doing mistakes, and it’s ok. But let’s keep a vibrant, helpful, enthusiastic community around this project. It’s fun, it’s great and a lot to learn from. So thank you and sorry if this comment is not really related to the issue.

from query.

Kiborgik avatar Kiborgik commented on June 8, 2024 6

@TkDodo why you are so toxic? Why need reproduction for obvious bug based on major update to framework. Anyway you will fix it near feature. Be proud, you closed this issue like a man, because someone doesn't have a reproduction for you

from query.

TkDodo avatar TkDodo commented on June 8, 2024 6

Imo the toxicity comes from people demanding time from open source maintainers without putting in the minimal required effort for themselves. Now you want me to create a nextJs14.1 project myself, and setup react query in the same way as you have to check if there is in even an issue on our end? Do you not think it's more likely that this is a nextJs issue rather than a React Query issue since nextJs just released a new version and it just so happens that you get errors like:

'useRef' is not exported from 'react' (imported as 'React').

as if I'm personally bundling react and leaving out useRef !? Just because the stack trace you're getting has react-query in there?

from query.

TkDodo avatar TkDodo commented on June 8, 2024 3

I really hope you've learned your lesson and won't waste maintainers' time without a reproduction in the future. Consider sponsoring the TanStack to fund our work 🙏

from query.

Kiborgik avatar Kiborgik commented on June 8, 2024 1

Yes it was a framework issue, to fix:

  1. remove browserslist[] from package.json
  2. delete .next folder
    source(vercel/next.js#60890 (comment))

Have a nice day

from query.

mvn-vietnguyen-dn avatar mvn-vietnguyen-dn commented on June 8, 2024 1

@TkDodo
Can you help me check this error? Thank you 🙇‍♂️
I'm using NextJS 14.0.4 and @tanstack/react-query ^5.18.0
image

from query.

Kiborgik avatar Kiborgik commented on June 8, 2024

build and production: working
dev: not working

from query.

TkDodo avatar TkDodo commented on June 8, 2024

Your minimal, reproducible example
no

YES. I'll re-open this once there is a reproduction

from query.

Kiborgik avatar Kiborgik commented on June 8, 2024

@TkDodo I not demand anything. I showed error and problem. Please compare your first answer where you closed a issue depends on something what you don't like and the last answer. I am sorry if my issue triggered you. The problem maybe in next.js, but everything works without react query and as I mentioned in second comment everything works in build and production, but not in development.

Also I checked other open issues (like #6734) and only what I did wrong - put Provider.tsx at other place of issue, why you closed only my issue?

from query.

TkDodo avatar TkDodo commented on June 8, 2024

I closed the issue because it has no reproduction, and I also said I'll reopen it once there is a reproduction. We've had reports in the past where useEffect was missing in React, I spend time looking into it and it turned out that next had a different version of React for edge deployments and it was just a huge waste of my time.

If the issue is important to you, as it clearly is, create a codesandbox with next14 that shows the error.

from query.

mateeyow avatar mateeyow commented on June 8, 2024

FWIW to solve this issue you can install @tanstack/query-core as a dev dependency since pnpm does not resolve it properly especially if preserveSymlinks is set to true

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.