Comments (8)
What's happening here is that, while our types are correct - they are extremely complex. Complex enough that we have to add an edgecase for only calculating a specific depth (in our case, 3 deep) so that TypeScript doesn't break.
This string is reading that 3-level depth and therefore breaking.
Tagging in our type-level perf expert @tannerlinsley to see if we can get together to investigate a potential fix
from form.
I’ll take a look
from form.
@chorobin might even be a better fit here. He knows way more about perf
from form.
Looking briefly I can see a few things that could be more efficient. I don't think these types are tail recursive optimised, is this why TS was breaking and you had to add a depth limit? Usually there's a recursive limit up to 100 with non-optimised and 1000 optimised.
from form.
If the depth limit can be modified (by manually adding types to extend it or otherwise), then it might make sense to choose a limit that is far beyond what could be reasonably expected for the form state, like 10 or so.
from form.
@chorobin the reason we limited depth was due to TS seemingly running into OOM problems without it. Help debugging would be immensely helpful
from form.
Do we have a reproducer of the OOM errors?
from form.
Confirmed to be fixed by #680! Thanks @chorobin 😄😄😄
from form.
Related Issues (20)
- Array fields do not run onChange validation HOT 2
- Mismatch in array handling between useForm and FormData HOT 3
- Error using useState & form.setFieldValue HOT 7
- Add a way to display only one error for a field HOT 3
- Calling `createFormFactory<FormData>` and using a validator adapter throw TS errors HOT 1
- onChangeAsyncDebounceMs not properly debouncing HOT 1
- TanStack/Angular - Error when resetting the form HOT 1
- Missing error when validating via form options instead of via field HOT 3
- Factory `onSubmit` function not invoked whenever factory.useForm gets provided with `onSubmit` itself HOT 2
- Unable to read properties in nested array table HOT 2
- Nested Values Disappear when using StrictMode HOT 5
- onMount Error is not revalidated when the user changes the input HOT 2
- server actions example errors when using zod adapter HOT 1
- Cannot infer types on arrays of union of objects HOT 1
- Moving subfields of array field mix their values HOT 1
- Bad performance with 100+ rows in an array field HOT 4
- insertFieldValue replaces item instead of adding a new one and shift existing items
- solid form createField failed to import `memo` from "solid-js/web" when used in solid-start ssr mode
- Issue with array + react + numbers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from form.