Field Array Validation Not Refreshing Properly When Field is Removed about form HOT 5 OPEN

Looks like we have a bug here, I'll check it out later this week! ☺️

from form.

@crutchcorn You worked a lot on array fields, so I'll summon you to ask for help! 😆

If you check the video recording below, there are subfields in form.fieldMeta:

• "people[0].name"
• "people[1].name"

When we delete "people[0].name", the values in form.values are updated properly, but the meta data in form.fieldMeta do not, because "people[0].name" stays the same (instead of getting the value of "people[1].name"), and "people[1].name" simply gets deleted.

I could dig deeper, but I thought maybe you could give me some pointers here since you've worked with array fields recently. ☺️

from form.

@fulopkovacs do you think this is in part due to this? #662

from form.

@fulopkovacs do you think this is in part due to this? #662

They might be related, but I tested the PR of the supposed fix for #662 (#700), and it seems like it does not solve the issue.

I'll look into it! (Thanks to #656, I'm much more comfortable with working on validation-related issues 🤣 )

from form.

Ok, I found the bug and made a fix locally, I will try to clean it up and commit it this week.

The main source of the problem is that the array field is not re-validated after one of its subfields gets removed. But, here are some interesting things that I found when I was investigating the issue:

• calling validate() on the array field itself did not re-validate the subfields (not sure if it's by accident or design), so I tried using validateAllFields() to quickly get the job done
• validateAllFields() didn't work, because the fieldInfo property of FormApi still contained data related to the deleted field, and validateAllFields() relies on it to get the fields that should be validated
• another fun fact: since the removeValue() method of FieldApi doesn't have an opts arg ({touch: boolean}), it can't pass it to this.form.removeFieldValue, which prevents the array field's meta data from being updated (it should happen here, it's fixed in #701 )

The fix I have locally deletes the data related to the last subfield from this.fieldInfo in removeFieldValue() before calling validateAllFields. This way we don't have errors and everything gets updated properly.

from form.