Dynamic class names about react-svg HOT 6 CLOSED

@Bartozzz this issue should be fixed if you want to try grabbing the latest version now.

from react-svg.

@Bartozzz that looks like expected behaviour to me?

In your example screenshot, I can see the icon class is showing up on the svg element. If you sent through icon is-active as the value for the className prop (say, when that render function was called again), then those two classes will show up on the svg element.

from react-svg.

Yes, the .icon class shows on the svg element on the first render, but it's keeps showing on the consecutives ones - even if themeIcon has changed. Maybe it happens only on my machine as I am using NW.js and the Node.js/Window context is messed up a little. At this moment I am adding the .is-active class to the parent element.

Anyway, can you provide a working, tested example that's adds a class to the ReactSVG element?

from react-svg.

I see what you mean now. This module delegates to SVGInjector, and I think that keeps an internal cache of the SVG's it loads, and if it determines an SVG has already been loaded, then it won't update it. I'd need to investigate further.

In the meantime it sounds like your workaround will be ok, I'm guessing (have yet to test this) you're doing something like wrapping ReactSVG in a div, and getting at the SVG element via a selector like .icon.is-active svg {}?

from react-svg.

Yup, that's exactly what I am doing.

from react-svg.

Closing, assuming the thumbs up meant things were all good? Feel free to post a new issue or reopen this one if you feel the issue isn't resolved.

from react-svg.