Git Product home page Git Product logo

Comments (2)

ntezak avatar ntezak commented on May 29, 2024

The following patch fixes the issue for me, but I am unsure if it breaks something else

diff --git a/plotille/_figure.py b/plotille/_figure.py
index 0fe4f9a..577194a 100644
--- a/plotille/_figure.py
+++ b/plotille/_figure.py
@@ -641,8 +641,6 @@ class Text:

 class Span:
     def __init__(self, xmin, xmax, ymin, ymax, lc):
-        assert 0 <= xmin <= xmax <= 1
-        assert 0 <= ymin <= ymax <= 1
         self._xmin = xmin
         self._xmax = xmax
         self._ymin = ymin
@@ -671,28 +669,16 @@ class Span:

     @classmethod
     def create(cls, xmin, xmax, ymin, ymax, lc=None):
-        if not (0 <= xmin <= xmax <= 1):
-            raise ValueError('xmin has to be <= xmax and both have to be within [0, 1].')
-        if not (0 <= ymin <= ymax <= 1):
-            raise ValueError('ymin has to be <= ymax and both have to be within [0, 1].')
-
         return cls(xmin, xmax, ymin, ymax, lc)

     def write(self, canvas, with_colors):
         color = self.lc if with_colors else None

-        # plot texts with color
-        xdelta = canvas.xmax_inside - canvas.xmin
-        assert xdelta > 0
-
-        ydelta = canvas.ymax_inside - canvas.ymin
-        assert ydelta > 0
-
         canvas.rect(
-            canvas.xmin + self.xmin * xdelta,
-            canvas.ymin + self.ymin * ydelta,
-            canvas.xmin + self.xmax * xdelta,
-            canvas.ymin + self.ymax * ydelta,
+            self.xmin,
+            self.ymin,
+            self.xmax,
+            self.ymax,
             color=color,
         )

from plotille.

tammoippen avatar tammoippen commented on May 29, 2024

Hi,

This is an issue with v3.8.0 . In master, the issue is already fixed, see this PR #42. It is just not published yet. Please have a try with master.

I added specific tests in 86ec904, which is part of #44 . When I finished that PR, I will publish a new version.

from plotille.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.