Git Product home page Git Product logo

Comments (6)

tajo avatar tajo commented on June 2, 2024

That's interesting. My guess would be some shared peer dependency got bumped and causing this (Ladle v3 bumped all its deps to the latest)?

Trying to search for __nominal in node_modules could be a good start.

from ladle.

moltar avatar moltar commented on June 2, 2024

Trying to search for __nominal in node_modules could be a good start.

Good idea!

But came up with nothing :(

ag -r --follow '__nominal' node_modules/

... nada ... 🤷🏼

I even searched entire GH for this string, and found no relevant packages that could be adding this.

https://github.com/search?q=%22__nominal%22+AND+%28language%3AJavaScript+OR+language%3ATypeScript%29+AND+NOT+path%3A.d.ts&type=code

from ladle.

moltar avatar moltar commented on June 2, 2024

Haha, jokes!! The string is in our codebase 😅

But this still does not explain why it has been all of a sudden added to the snapshot. It has been there for 3+ years.

Perhaps the snapshotting tool used to not consider __* prefixes and now it does.

Digging further.

from ladle.

moltar avatar moltar commented on June 2, 2024

I am checking the diff of the package.json for these versions and nothing really jumps at me.

https://app.renovatebot.com/package-diff?name=@ladle%2freact&from=2.17.2&to=3.0.0#d2h-519664

Do you have any ideas?

All of the deps seem to be not so relevant. But maybe they are pulling in their own deps.

from ladle.

tajo avatar tajo commented on June 2, 2024

But maybe they are pulling in their own deps.

This probably.

from ladle.

tajo avatar tajo commented on June 2, 2024

I don't think there's anything we can do on our side?

from ladle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.