Comments (5)
Thanks for the repro. The HMR breaks when story is created through the bind
:
export const MyTest = MyComponent.bind({});
is used.
It works when args are assigned directly.
This is definitely a bug.
from ladle.
Can you be more specific? Is this only about the source code addon? HMR seems to be working fine for me.
Are you changing a code of an existing story? Are you creating a new story? A new story file?
Also, something I've noticed on the source code is that it would only watch for .stories. and does not respect the glob we override (e.g: if I want my stories to have .fixture instead)
Is this the same issue?
from ladle.
@tajo Indeed it was a little vague therefore I have updated the initial description with a better replication.
Can you be more specific? Is this only about the source code addon? HMR seems to be working fine for me.
Are you changing a code of an existing story? Are you creating a new story? A new story file?
I'm just changing an existing story (with a different glob), there's nothing to do with the source code addon, it's just the core functionalities of Ladle.
Is this the same issue?
Well I'm not exactly sure but since I'm using a different glob and I saw that catch on the ids, I do believe it might be related because in our codebase none of the files/components includes the story principle (we are migrating from Cosmos)
from ladle.
@tajo When is the next release that will include this bug fix?
from ladle.
This week for sure. Working on some other bugfixes.
from ladle.
Related Issues (20)
- Side panel story name not readable when using longer names or folder nesting HOT 1
- Version 3 supports only React 18+, it's an undocumented breaking change HOT 1
- Deno support HOT 1
- Allow duplicate story name HOT 2
- Missing Accessibility Report button with @ladle/react v3.1.0 and up HOT 2
- ladle.css leaks on @reach/dialog inside stories HOT 1
- Internal server error: Header name must be a valid HTTP token [":path"] HOT 2
- ladle build error HOT 3
- Should the msw implementation be created as an independent plugin? HOT 2
- RTL config using MDX code block breaks formatting HOT 1
- Stylesheet ordering bug with @mui/material and styled-components HOT 9
- Range control with a default value of zero does not adopt default value
- Source maps are broken
- MDX anchor links do not work
- Allow exports in `export` block HOT 5
- Toggling view should retail the filter query
- Vite HMR config does not override Ladle default config HOT 2
- Ladle seems to conflict with remix vite plugin HOT 4
- Allow export function which are not in the same file HOT 2
- Code blocks in .mdx files display warnings in browser console HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ladle.