Git Product home page Git Product logo

Comments (5)

tajo avatar tajo commented on August 22, 2024 2

Thanks for the repro. The HMR breaks when story is created through the bind:

export const MyTest = MyComponent.bind({});

is used.

It works when args are assigned directly.

This is definitely a bug.

from ladle.

tajo avatar tajo commented on August 22, 2024 1

Can you be more specific? Is this only about the source code addon? HMR seems to be working fine for me.

Are you changing a code of an existing story? Are you creating a new story? A new story file?

Also, something I've noticed on the source code is that it would only watch for .stories. and does not respect the glob we override (e.g: if I want my stories to have .fixture instead)

Is this the same issue?

from ladle.

underfisk avatar underfisk commented on August 22, 2024

@tajo Indeed it was a little vague therefore I have updated the initial description with a better replication.

Can you be more specific? Is this only about the source code addon? HMR seems to be working fine for me.

Are you changing a code of an existing story? Are you creating a new story? A new story file?

I'm just changing an existing story (with a different glob), there's nothing to do with the source code addon, it's just the core functionalities of Ladle.

Is this the same issue?

Well I'm not exactly sure but since I'm using a different glob and I saw that catch on the ids, I do believe it might be related because in our codebase none of the files/components includes the story principle (we are migrating from Cosmos)

from ladle.

underfisk avatar underfisk commented on August 22, 2024

@tajo When is the next release that will include this bug fix?

from ladle.

tajo avatar tajo commented on August 22, 2024

This week for sure. Working on some other bugfixes.

from ladle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.