Styles in loops about tinygraphs HOT 6 CLOSED

Interesting, I will give it a try,
thanks for the feedback.

from tinygraphs.

@ajstarks when the I use the same style over the whole loop it definitly makes sense to use canvas.Gstyle(), Thanks.

In the case of multiple styles in the same loop it is a bit harder as you would have to create a loop for each style.

Should I also try to use Gstyle in this type of scenario?

for ... {
    style1 := ....
    style2 := ....
    if something {
        canvas.Line(...., style1)
    } else { 
        canvas.Line(..., style2)
    }
}

from tinygraphs.

Nah, it's not worth it in the case you cite. Gstyle is useful for invariants. However, if you can make the decision outside of the loop, you can assign two styles before the loop and then apply them.

      style1 := ....
      style2 := ...
      for ... {
         if something {
              canvas.Line(...., style1)
          } else {
              canvas.LIne(...., style2)
         }
     }

Another useful pattern is to combine Gstyle() for the common style items, and then add variation in the loop as needed.

from tinygraphs.

Cool, thanks

I was able to clean some of the roots where I was creating a fill each time.
See --> 60203d4

And I also manage to use the pattern you described (Gstyle() then add variations).
See --> c6cafeb

from tinygraphs.

in revision c6cafeb you can eliminate the var fill, and then do:

    if colorIndex[yL] == 0 {
        canvas.Polygon(xs, ys, draw.FillFromRGBA(colorMap[yL]))
    }

from tinygraphs.

good spot, I will simplify that 👍

from tinygraphs.