Git Product home page Git Product logo

Comments (5)

thecrypticace avatar thecrypticace commented on August 24, 2024 1

I think we're aiming to tag a release today — but if not then tomorrow. 👍

In the meantime you can use our insiders build once it's updated (may take a few minutes):

npm install @headlessui/react@insiders

from headlessui.

thecrypticace avatar thecrypticace commented on August 24, 2024

Hey! So this is a known limitation of TypeScript in how it interprets JSX. Children in JSX/TSX can't be "typesafe" and as a result are not able to infer their types, props, etc… based on the parent component.

Matt Pocock has an article about this topic that details some of the problems. But the gist is that we'd need to find a way to design the types such that the "children" of Combobox are only of a certain type — this would then allow us to infer the props type. Sadly this is just not possible today.

This is why the type in the render prop is typed as unknown — to push people to type it themselves. I'd suggest typing it explicitly like this:

<HeadlessComboboxOptions>
  {({ option } : { option: MyOptionType }) => (
    <HeadlessComboboxOption></HeadlessComboboxOption>
  )}
</HeadlessComboboxOptions>

Hope that helps 👍

from headlessui.

jussirantala avatar jussirantala commented on August 24, 2024

@thecrypticace I actually tried to type it myself but I get this:
image

typescript version 5.4.5

from headlessui.

jussirantala avatar jussirantala commented on August 24, 2024

If the type was any instead of unknown, I think it would work.

from headlessui.

thecrypticace avatar thecrypticace commented on August 24, 2024

I swear worked at one point but yeah aliasing to a different type does not in function argument position. Will get a fixed merged in for that.

from headlessui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.