Git Product home page Git Product logo

Comments (27)

Taiko2k avatar Taiko2k commented on August 25, 2024 1

There is actually in the horizontal top tabs, albeit subtle, though indeed perhaps the playlist side panel should have this as well

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024 1

I think I like idea 1, gives clearer separation than the highlight, without being too overbearing. I'm thinking yellow.

screenshot from 2019-02-08 19-43-54

The main reason this doesn't follow the top panel colours is this part of the UI is intended look good for any given background colour so it can work well with the auto theme function.

screenshot from 2019-02-08 19-47-47

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Yeah, I was talking about playlist side panel =)

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

Btw you can right click the play button which quickly takes you to the playing playlist.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

I know, a very useful feature! Left click also works.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

I can mirror the subtle shading used in the top panel here like this:

screenshot from 2019-02-08 12-41-04

I used to have a large distinct yellow play sign to indicate this, but I didn't like the aesthetic of that.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

It's hard to see.
I'm thinking about these options:

Alt Text

Alt Text

  1. Or we can just use a different text color for the playing playlist

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024
  1. highlighting like horizontal tabs maybe

alt text

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

What do you think about the option to disable on/off playlists switches? I don't use it at all.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

I could make it so its disabled along with disabling the top tabs, since managing top tabs are the main function of the switches. Maybe I could leave just the yellow indicator so it still serves the purpose of displaying which playlist is playing.

The switches also serve an obscure function of being skipped when transitioning from previous playlists. Though it's not even a feature I've ever used.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

I could make it so its disabled along with disabling the top tabs, since managing top tabs are the main function of the switches. Maybe I could leave just the yellow indicator so it still serves the purpose of displaying which playlist is playing.

Looks like a good idea to me.
Although I think some users may find these switches useful even when top tabs are disabled.
Do you plan to implement some kind of Playlists Manager, where users can enable/disable playlists, lock playlists, sort playlist (by creation date, play time)?

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

I hadn't considered a playlist manager like that. I'm not sure about the idea though, none of those features seem necessary to me. Perhaps I'm not familiar with the use cases.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Player which I was using on windows has Playlists Manager, but I never used it.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

In regards to #36

I think I might have better solution, how about just adding a setting titled Always pin new playlists, then you could disable this setting, and unpin all existing playlists, then the top tabs would be effectively disabled.

I think this makes more sense in the context of how things are intended to work. You could still use top panel tabs if you later wanted to, and there's no edge cases where functionality is broken.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Always pin new playlists
So the idea is that top tabs = reัent pined playlists
I see some problems with top tabs:

  1. To see the most resent playlists we must unpin some old playlists, because they are hidden. (Not a problem if you only use few playlists)
  2. Width of the tabs depends of the playlist' name lengths and it can be very long (e.g. "artist-album").
  3. The number of available tabs is limited because we can't scroll them, especially when player window is not maximized.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

Well, not recent, just shows the first that will fit. With the idea that the user would indeed need to unpin others if they want to see more. (Or re-order them)

So those are indeed limitations, but I don't see any solution that's a hugely improved paradigm.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Well, not recent, just shows the first that will fit. With the idea that the user would indeed need to unpin others if they want to see more. (Or re-order them)

Do you think that the users will pin/unpin playlists? Because it is rather unique concept. Other players just have horizontal or vertical playlists "tabs"

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

I think top tabs give the most convenience, especially if the window is sized small, or the user has few playlists open. But becomes cumbersome if there's many playlists. Once a user has many playlists, they can transition to using the side tabs, and pinning and unpinning for quick access to individual tabs.

Yes it's a little unorthodox but I think it works alright, and is reasonably aesthetic, I think removing parts of it as it works currently would be a downgrade.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

Hmm, I'm not sure I'm happy with option 1 after all, it does conflict with the pin function (in the case if pinning and unpinning the playing playlist, where would not be correct feedback for that)

Its also more difficult juggling multiple colours between light and dark themes

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

What about different text color for the playing playlist? We already have quite a colorful playlist.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

I don't think that would work well, as mentioned, the background could be any colour, so it wouldn't consistently look good.

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Another variant with marker. But it will look weird if we disable the pin switcher.

alt text

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Another idea:

alt text

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

Heres my current working concept

screenshot from 2019-02-24 12-27-16

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

Not bad I think. And playlist will also be highlighted (like selected playlist)?
How will it look on another theme? Maybe the marker color should depends on the main theme color.

from tauon.

Taiko2k avatar Taiko2k commented on August 25, 2024

As I currently have it, there is no highlight, and does follow theme colour.

screenshot from 2019-02-24 14-11-50

from tauon.

Solarunit avatar Solarunit commented on August 25, 2024

I think marker+highlight looks better on screenshot, but having 2 highlighted playlists will look confusing.

from tauon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.