Git Product home page Git Product logo

Comments (3)

taiki-e avatar taiki-e commented on May 20, 2024

In a build script, the RUSTC environment variable can be used for this purpose, but in a subcommand, the RUSTC environment variable has a different meaning.

If we need the major-minor-patch version of the toolchain (e.g., cargo-hack's --version-range), cargo --version --verbose is fine, but if we need the exact toolchain date of nightly rustc, cargo --version --verbose is not enough.

So I think the correct action here is just to remove this heuristic. (IICU, the way introduced in #79 should work well without rustc version-based heuristics.)

from cargo-llvm-cov.

taiki-e avatar taiki-e commented on May 20, 2024

So I think the correct action here is just to remove this heuristic. (IICU, the way introduced in #79 should work well without rustc version-based heuristics.)

In fact, it relies on information from rustc here as well, but that can be avoided.

let rustlib = sysroot.join(format!("lib/rustlib/{}/bin", rustc.host));

from cargo-llvm-cov.

taiki-e avatar taiki-e commented on May 20, 2024

Oh, actually I can find the rustc binary based on the sysroot.

from cargo-llvm-cov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.