Git Product home page Git Product logo

Comments (6)

taiki-e avatar taiki-e commented on July 18, 2024 1

The behavior changes included in this release only change a case that previously resulted in an error (#360), so I guess the problem is most likely a mismatch between the LLVM version of LLVM tools and the LLVM version of rustc.

IIUC, CI using rustc beta (LLVM 18.1.2) and Homebrew LLVM 17.0.6. (When 0.6.8 was tested they were probably both LLVM 17.)

Considering that it appears that CI uses rustup to install rustc, a reasonable solution to this would be to remove llvm-tools-related environment variables and use llvm-tools-preview, which is distributed via rustup. Alternatively, using stable rustc instead of beta for testing would also work. The latter does not address the underlying problem, though.


By the way, the title of this issue is "build failure", but it appears that it is the test that is actually failing.

from cargo-llvm-cov.

taiki-e avatar taiki-e commented on July 18, 2024

(Unrelated to this issue, but it appears that homebrew-core uses the crate generated by cargo new --bin to test. Since the crate generated that way does not contain any test, I think it would be better to use the crate generated by cargo new --lib.)

from cargo-llvm-cov.

chenrui333 avatar chenrui333 commented on July 18, 2024

IIUC, CI using rustc beta (LLVM 18.1.2) and Homebrew LLVM 17.0.6. (When 0.6.8 was tested they were probably both LLVM 17.)

I was thinking the same. Thanks for confirming it.

By the way, the title of this issue is "build failure", but it appears that it is the test that is actually failing.

oh, that is mainly it is because I think it is build related as it is a version bump (which caused the test failure)

from cargo-llvm-cov.

chenrui333 avatar chenrui333 commented on July 18, 2024

(Unrelated to this issue, but it appears that homebrew-core uses the crate generated by cargo new --bin to test. Since the crate generated that way does not contain any test, I think it would be better to use the crate generated by cargo new --lib.)

that makes sense to me, do you want to take on a PR to do the update :)

from cargo-llvm-cov.

taiki-e avatar taiki-e commented on July 18, 2024

Filed Homebrew/homebrew-core#168319 to fix.

from cargo-llvm-cov.

taiki-e avatar taiki-e commented on July 18, 2024

The problem on the Homebrew side has been fixed in Homebrew/homebrew-core#168319 & cargo-llvm-cov documentation has also been updated and a note on compatibility when setting LLVM_* env vars has been duplicated in an easy-to-find place (fa229e3).

from cargo-llvm-cov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.