Comments (4)
@bfwg It is not always null, only in the case, that there is no authorization request header. The problem is, that the filter now filters every request and many times there is no authorization header. It would be better if the filter only filters requests that should be secured based on the security configuration.
from jwt-spring-security-demo.
@bfwg & @szerhusenBC I have a question, assuming doFilterInternal method is setting Authentication with every valid request (by using SecurityContextHolder.getContext().setAuthentication(authentication);
)
If there are multiple requests will there be a confliction? For example, if I am using the authentication for Authorization (@PreAuthorize("@validator.isAuthorised(true,#request,authentication)")
) on rest end points to determine the access will it be safe?
from jwt-spring-security-demo.
Hi @szerhusenBC , you are correct. This is how I did to filter base on response path: https://github.com/bfwg/springboot-jwt-starter/blob/master/src/main/java/com/bfwg/config/WebSecurityConfig.java#L104
I imagine there must be a more elegant way to handle this. Please let me know what you think.
from jwt-spring-security-demo.
@bfwg While migrating to Spring Boot 2 I did some fixes and optimizations. It seems that the filter now only is invoked for the secured URLs. So I'm closing this ticket now.
from jwt-spring-security-demo.
Related Issues (20)
- HI, why ADMIN not ROLE_ADMIN ? HOT 2
- Unable to access API via curl HOT 4
- Token Invalidation HOT 5
- dependency injection problem HOT 1
- Share DB schema HOT 2
- String cannot be resolved to a type HOT 2
- where does BCryptPasswordEncoder be used? HOT 2
- Add an endpoint for refreshing tokens HOT 7
- SecurityContextHolder setAuthentication is unused?
- setting JWTs in local storage is a security risk. HOT 1
- Save new user
- Dependency org.apache.tomcat.embed:tomcat-embed-core, leading to CVE problem HOT 2
- Dependency org.apache.tomcat.embed:tomcat-embed-core, leading to CVE problem HOT 1
- Error executing DDL "# noinspection SqlNoDataSourceInspectionForFile" via JDBC Statement HOT 1
- problem starting app
- CrossOrgin HOT 2
- AuthenticationRestController.createAuthenticationToken getting UserDetails twice HOT 1
- Encoded password does not look like BCrypt HOT 2
- JwtAuthenticationEntryPoint implements Serializable HOT 1
- canTokenBeRefreshed is reduntant HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jwt-spring-security-demo.