Git Product home page Git Product logo

Comments (4)

szerhusenBC avatar szerhusenBC commented on May 22, 2024 1

@bfwg It is not always null, only in the case, that there is no authorization request header. The problem is, that the filter now filters every request and many times there is no authorization header. It would be better if the filter only filters requests that should be secured based on the security configuration.

from jwt-spring-security-demo.

arkaprovo avatar arkaprovo commented on May 22, 2024

@bfwg & @szerhusenBC I have a question, assuming doFilterInternal method is setting Authentication with every valid request (by using SecurityContextHolder.getContext().setAuthentication(authentication);)
If there are multiple requests will there be a confliction? For example, if I am using the authentication for Authorization (@PreAuthorize("@validator.isAuthorised(true,#request,authentication)")) on rest end points to determine the access will it be safe?

from jwt-spring-security-demo.

bfwg avatar bfwg commented on May 22, 2024

Hi @szerhusenBC , you are correct. This is how I did to filter base on response path: https://github.com/bfwg/springboot-jwt-starter/blob/master/src/main/java/com/bfwg/config/WebSecurityConfig.java#L104
I imagine there must be a more elegant way to handle this. Please let me know what you think.

from jwt-spring-security-demo.

szerhusenBC avatar szerhusenBC commented on May 22, 2024

@bfwg While migrating to Spring Boot 2 I did some fixes and optimizations. It seems that the filter now only is invoked for the secured URLs. So I'm closing this ticket now.

from jwt-spring-security-demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.