[Bug] webpack 5 updated files do not trigger rebuilds about webpack-virtual-modules HOT 9 CLOSED

ok one issue is that https://github.com/sysgears/webpack-virtual-modules/blob/master/index.js#L65

is a Set in webpack5, that seems to fix the issue sometimes (i can only get it actually produce updated files when running the server with the debugger attached, so maybe a timing issue?)

from webpack-virtual-modules.

More context, it's not the debugger its whether --mode development is set, or more specifically if cache: true so something is not busting the cache here

from webpack-virtual-modules.

@jquense Yes, the new watchpack was significantly changed and someone needs to find out how to properly emit the changes with this new version.

from webpack-virtual-modules.

It seems that Webpack 5 watch support is currently incomplete

CC @samcooke98

from webpack-virtual-modules.

I've narrowed down the issue a bit. The core problem is that watchers are producing a map of timestamps that are missing the virtual files. basically on rebuilds this line: https://github.com/webpack/watchpack/blob/master/lib/DirectoryWatcher.js#L737 nulls out the initial mtime for the virtual file, e.g. the watcher knows about the virtual file path but (obviously) doesn't know where it is.

Basically the timestamp stays null through rebuilds which breaks the "should rebuild" check. It seems like v5 has the opposite problem from #66 in that files never get rebuilt without the timestamps.

It should be said that this is a bug in v5, the value is a FileSystemInfoEntry object not just a timestamp. That will fix the problem for rebuilds after the first one. For the first recompile the null gets stuck until another build happens, at least in my repo.

from webpack-virtual-modules.

An alternative approach here might be to wrap the WatchFileSystem directly, fixing up the map here: https://github.com/webpack/webpack/blob/master/lib/node/NodeWatchFileSystem.js#L80 would (i think) solve the problem and avoid dealing with the craziness of watchpack

from webpack-virtual-modules.

Yeah, I'm also looking at these getTimeInfoEntries and thinking how can we deal with them? The easiest way to deal with them would be preferable

from webpack-virtual-modules.

We can call

              fileWatcher.directoryWatcher.setFileTime(
                modulePath,
                +time,
                false,
                false,
                'change'
              );

it fixes the timing, but its not the end of the journey, it seems

from webpack-virtual-modules.

@jquense The fix published in [email protected]

from webpack-virtual-modules.