Comments (13)
Bruceforce
commented on July 25, 2024
Hi,
I tried with 60d873b and got the following
11-11 20:41:45.700 10456 10543 E ExecutorService: java.lang.IllegalStateException: FilenameUtils.normalizeNoEndSeparator(path, true) must not be null
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.utils.PathUtils.normalizePath(PathUtils.kt:29)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.utils.PathUtils.getParentPath(PathUtils.kt:42)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.beans.FileInfo.<init>(FileInfo.kt:41)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.beans.FileInfo$Builder.build(FileInfo.kt:163)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.bep.IndexHandler.pushRecord(IndexHandler.kt:168)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$ProcessingRunnable.doHandleIndexMessageReceivedEvent(IndexHandler.kt:406)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$processBg$1.runProcess(IndexHandler.kt:329)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$ProcessingRunnable.run(IndexHandler.kt:356)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$1.invoke(ExecutorUtils.kt:31)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$1.invoke(Unknown Source:0)
11-11 20:41:45.700 10456 10543 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$2.call(ExecutorUtils.kt:40)
11-11 20:41:45.700 10456 10543 E ExecutorService: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
11-11 20:41:45.700 10456 10543 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
11-11 20:41:45.700 10456 10543 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
11-11 20:41:45.700 10456 10543 E ExecutorService: at java.lang.Thread.run(Thread.java:764)
I also tried with a new empty folder and the app didn't crash this time. Then I added a few files to it and still no crash this time.
from syncthing-lite.
l-jonas
commented on July 25, 2024
@Bruceforce Before/ after the crash, there should be a line starting with "PathUtils.normalizePath: ". This one is relevant because it shows what the path which couldn't be processed looks like. You can replace the words by other strings, the structure with slashes and dots and whatever separator is important.
from syncthing-lite.
Bruceforce
commented on July 25, 2024
@l-jonas ah sorry. I left the "net.syncthing" filter on, but there was no "net.syncthing" in that line. Do you just need the one line with PathUtils before the crash or all other lines with PathUtils before the crash too? Here is the line right above the crash - otherwise I'd have to replace some stuff.
11-11 20:41:45.698 10456 10543 W PathUtils: PathUtils.normalizePath: ~$Brief.dot/..
from syncthing-lite.
l-jonas
commented on July 25, 2024
This line is enough. I could reproduce the bug by creating a file called ~Test.txt
from syncthing-lite.
l-jonas
commented on July 25, 2024
@Bruceforce Could you please test if the referenced pull request solves this crash for you (it works for me)?
from syncthing-lite.
Bruceforce
commented on July 25, 2024
@l-jonas thanks for the fix! The one previous with "~" seems to work no. But it crashes again with:
11-13 01:55:34.332 3174 3403 V IndexHandler: discarding record = FileRecord{folder=id-here, path=Some Folder/XX_Xxxxxx-Xx_Xxx_Xxxx-(xxxxxx)-1234-X4, size=null, lastModified=Fri Jan 15 01:05:15 GMT+01:00 2016, type=DIRECTORY, last version = Version{id=3830528999313350446, value=1}}, modified before local record
11-13 01:55:34.333 3174 3403 E ExecutorService: java.lang.IllegalArgumentException: provided path is invalid
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.utils.PathUtils.assertPathValid(PathUtils.kt:45)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.utils.PathUtils.getFileName(PathUtils.kt:79)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.beans.FileInfo.<init>(FileInfo.kt:40)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.beans.FileInfo$Builder.build(FileInfo.kt:163)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.bep.IndexHandler.pushRecord(IndexHandler.kt:168)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$ProcessingRunnable.doHandleIndexMessageReceivedEvent(IndexHandler.kt:406)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$ProcessingRunnable.doHandleIndexMessageReceivedEvent(IndexHandler.kt:377)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$storeAndProcessBg$1.runProcess(IndexHandler.kt:342)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor$ProcessingRunnable.run(IndexHandler.kt:356)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$1.invoke(ExecutorUtils.kt:31)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$1.invoke(Unknown Source:0)
11-13 01:55:34.333 3174 3403 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$2.call(ExecutorUtils.kt:40)
11-13 01:55:34.333 3174 3403 E ExecutorService: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
11-13 01:55:34.333 3174 3403 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
11-13 01:55:34.333 3174 3403 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
11-13 01:55:34.333 3174 3403 E ExecutorService: at java.lang.Thread.run(Thread.java:764)
from syncthing-lite.
l-jonas
commented on July 25, 2024
@Bruceforce The message from the discarded record is triggered when the FileInfo is already created (but the exception is thrown during creating it) -> The log does not offer the required details. Please do it again with 46bef2e.
from syncthing-lite.
Bruceforce
commented on July 25, 2024
@l-jonas sorry for the late reply, I was very busy the last few days.
11-17 02:06:38.348 2946 3017 E ExecutorService: java.lang.IllegalArgumentException: provided path XX Xxxxxx/Xxxxxxxx..._Xxx_Xxxxx is invalid
from syncthing-lite.
l-jonas
commented on July 25, 2024
@Bruceforce To make sure that I read it correctly: Are the "..." part of the path or is it just a placeholder for a long string?
from syncthing-lite.
Bruceforce
commented on July 25, 2024
@l-jonas Only placeholder are X and x. So "..." is part of the folder name.
from syncthing-lite.
l-jonas
commented on July 25, 2024
@Bruceforce The ".." was a problem (even if it was only somewhere and not a single element). This should be fixed with c9f3c48 (this is the version with the more detailed error logging in case there is more)
from syncthing-lite.
Bruceforce
commented on July 25, 2024
@l-jonas this seems to fix all my awkward file and folder name issues. However the app crashed sometimes while loading the index and I had to restart it. After a few restarts it completed the download of the index. The error was
11-18 01:20:16.068 25041 26050 E ExecutorService: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@dc58468 rejected from java.util.concurrent.ThreadPoolExecutor@be14081[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 291]
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2078)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:843)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1389)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.Executors$DelegatedExecutorService.submit(Executors.java:633)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt.submitLogging(ExecutorUtils.kt:38)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt.submitLogging(ExecutorUtils.kt:31)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor.processBg(IndexHandler.kt:327)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.bep.IndexHandler$IndexMessageProcessor.handleIndexMessageReceivedEvent(IndexHandler.kt:319)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.bep.IndexHandler.handleIndexMessageReceivedEvent(IndexHandler.kt:141)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.bep.ConnectionHandler$startMessageListenerService$1$1.invoke(ConnectionHandler.kt:396)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.bep.ConnectionHandler$startMessageListenerService$1$1.invoke(ConnectionHandler.kt:48)
11-18 01:20:16.068 25041 26050 E ExecutorService: at net.syncthing.java.core.utils.ExecutorUtilsKt$submitLogging$2.call(ExecutorUtils.kt:40)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.FutureTask.run(FutureTask.java:266)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
11-18 01:20:16.068 25041 26050 E ExecutorService: at java.lang.Thread.run(Thread.java:764)
from syncthing-lite.
l-jonas
commented on July 25, 2024
I created a new issue for the new error.
from syncthing-lite.
Related Issues (20)
- crash if changing share folder flag too fast
- encrypt temporarily data
- Back arrow behaviour HOT 5
- block recycling
- Cannot open PDFs with spaces in file name
- Cannot open PDFs with umlauts in file name HOT 1
- How to use the protocol implementation outside of this repository? HOT 7
- Incoming new device connections are ignored HOT 6
- TLS fails on Android 7.0 HOT 9
- Non-local initial discovery doesn't work HOT 2
- [Question] Can Syncthing Lite Sync Files From SD Card? HOT 1
- How Do You Add A Folder? HOT 1
- Can't connect to any devices. IOE: Operation not permitted HOT 4
- java.util.NoSuchElementException: List is empty.
- Error pop-up without using app
- IPv6 is not used
- feature request: keep individual files in sync (similar to dropbox)
- Better download UI
- Doesn’t support Binary Eye as the barcode scanner
- 003
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from syncthing-lite.