Git Product home page Git Product logo

Comments (6)

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

Yes, I noticed that as well. Something seems to have changed in the core JavaScript.

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

Just checked it again - and it is working now again. Maybe an caching issue?

from subsectionmanager.

icek avatar icek commented on July 17, 2024

if you are using only one subsection it's working or if this is first of all created subsections. This is becuse you are always generating taglists for all sections and then you are showing via js only one: subsectionmanager.find('ul.inline').hide().filter('.section' + id).show(); in settings.subsectionmanager.js. The code for finding input in core js is: var input = list.prev().find('input')[0];, so when there are any hidden it doesn't find anything.

Proper tag list should be filterer in php not by js. Quick workaround in js is to replace mentioned above line: subsectionmanager.find('ul.inline').hide().filter('.section' + id).show(); to subsectionmanager.find('ul.inline').show().filter(':not(.section' + id+')').remove();

from subsectionmanager.

icek avatar icek commented on July 17, 2024

ok, after more investigations I know why you are filtering that way.
My new solution is to change: subsectionmanager.find('ul.inline').hide().filter('.section' + id).show() to: subsectionmanager.find('ul.inline').hide().filter('.section' + id).show().insertBefore(subsectionmanager.find('ul.inline:first'));

Now section related taglist is moved just after label/input, so list.prev().find('input')[0]; works properly. I didn't test this with only one subsection!

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

Ah, I see. Thanks for investigating. I'll have to revise the whole preference pane of the Subsection Manager because I still have to implement the Stage settings. So maybe it's time to rethinks the whole way the preferences for subsection work.

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

This has been fixed in my working copy which I will push to GitHub as soon as the preferences are fully functional.

from subsectionmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.