Git Product home page Git Product logo

Comments (11)

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

I think the $mode is used for output simulation. But I'm not sure. Has something changed in this area of Symphony?!

from subsectionmanager.

michael-e avatar michael-e commented on July 17, 2024

I think is has to do with formatted vs. unformatted output. For backward compatibility Alistair even included this in line 168 of field.textarea.php:

if ($mode == null || $mode == 'formatted') {
    ...
}

This means that you have decide if you want to output the formatted version or not. It would probably be the best to look up the desired output in the related section and set the parameter accordingly (formatted/unformatted, I guess).

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

Ah yes, that makes sense. Subsection Manager isn't backwards compatible at all so we should not have to care about that. If this is about the formatted and unformatted setting we should start thinking about a way how to integrate the included elements settings directly into the data source editor.

from subsectionmanager.

michael-e avatar michael-e commented on July 17, 2024

What about displaying them together with their section name? Let's say we have a section called "media":

  • media: name
  • media: file
  • media: description

from subsectionmanager.

michael-e avatar michael-e commented on July 17, 2024

Sorry, it must be like this:

  • media: name
  • media: file
  • media: description: formatted
  • media: description: unformatted

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

That's a good idea - or their field name. E. g. a Subsection Manager field with the name 'photos' (linking to your media section):

  • photos: name
  • photos: file
  • photos: description: unformatted
  • photos: description: formatted

from subsectionmanager.

michael-e avatar michael-e commented on July 17, 2024

Exactly.

  • section name: field name: formatting (if applicable)

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

I think I'll have to investigate how the textarea field handles the implementation of these different types.

from subsectionmanager.

nickdunn avatar nickdunn commented on July 17, 2024

The Textarea is broken in that its appendFormattedElement doesn't have a default set for $mode. All other fields do. I believe this has been fixed in 2.0.7 or 2.0.8, so it's not actually a bug with Subsection.

from subsectionmanager.

michael-e avatar michael-e commented on July 17, 2024

Looks like it was fixed in 2.0.8. So extension compatibility might be changed to 2.0.8+.

from subsectionmanager.

nilshoerrmann avatar nilshoerrmann commented on July 17, 2024

Great - thanks for the feedback.

from subsectionmanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.