[RFC] Apc polyfill about polyfill HOT 5 CLOSED

note that their polyfill of APCIterator is broken.

Btw, it is weird that @sanis created this as a fork on the Symfony apcu polyfill, as there is no reason to share the history (they are entirely different codebases)

from polyfill.

Putting it in the same polyfill does not make sense:

• loading both at the same time does not make sense (infinite loop)
• code using apcu_* functions has no reason to require a APC polyfill.

Btw, I'm rather -1 on this, for several reasons:

• our goal with polyfills is to enable writing future-proof code, not writing code based on deprecated/removed APIs
• the fact that it would trigger infinite loops when you load the polyfills for both APC and APCu without having these extensions enabled looks quite bad.

from polyfill.

I found an existing version of this outside of symfony polyfills - https://github.com/sanis/polyfill-apc
If its not part of what Symfony whats to provide then ill use the external one.
Btw, its not going to have infinite loops because both polyfills check for the module before defining functions.

from polyfill.

Yeah, that's really weird :) My bad. I will try to fix it in near future.

from polyfill.

It's funny to fork it, but what's wierd is to basically copy-paste the code and made small adjustments, then override the copyright of file (while leaving copyright of package)...

from polyfill.