hex2bin() returns false if NUL bytes are in decoded string about polyfill HOT 4 CLOSED

Can you give a simple example that does not lead to the same result as when using the built-in function?

from polyfill.

fuhrymbp :: ~ » php --version
PHP 5.5.30 (cli) (built: Oct 23 2015 17:21:45) 
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2015 Zend Technologies
fuhrymbp :: ~ » php -r 'echo hex2bin("6162006364");' | xxd
0000000: 6162 0063 64                             ab.cd

from polyfill.

No indication of a special case for \0 anywhere in PHP 5.4/5.5/7.0:
https://github.com/php/php-src/blob/PHP-5.4.45/ext/standard/string.c#L157
https://github.com/php/php-src/blob/PHP-5.5.33/ext/standard/string.c#L157
https://github.com/php/php-src/blob/PHP-7.0.5/ext/standard/string.c#L157

And @fuhry's example above shows that the PHP 5.5 version does not reject hex strings with 00 in it. As an ugly workaround, we're doing some really nasty as a post-install composer thing:

    "scripts": {
        "post-autoload-dump": [
            "echo 'Replacing broken hex2bin in Symfony ...'",
            "sed -i 's/p\\\\Php54::hex2bin/\\\\Util\\\\StringUtil::hex2bin/g' vendor/symfony/polyfill-php54/bootstrap.php",
            "grep StringUtil vendor/symfony/polyfill-php54/bootstrap.php"
        ]
    }

Merging the pull would make our lives a lot easier :-D

from polyfill.

Just noticed that someone else is having the same issue: #46

from polyfill.