Tests fail on PHP 7.3 about polyfill HOT 10 CLOSED

Closing as the CI is green on 7.3, which means this has been fixed - correct?

from polyfill.

@nicolas-grekas , I can confirm the problem for Mac. Tests fail for php 7.3.2 and pass fine for 7.1.25.
For instance, Normalizer constants values changed.

7.1.25

php > echo phpversion('intl');
1.1.0
php > var_dump((new \ReflectionClass(Normalizer::class))->getConstants());
array(9) {
  ["NONE"]=>
  int(1)
  ["FORM_D"]=>
  int(2)
  ["NFD"]=>
  int(2)
  ["FORM_KD"]=>
  int(3)
  ["NFKD"]=>
  int(3)
  ["FORM_C"]=>
  int(4)
  ["NFC"]=>
  int(4)
  ["FORM_KC"]=>
  int(5)
  ["NFKC"]=>
  int(5)
}

7.3.2

php > echo phpversion('intl');
7.3.2
php > var_dump((new \ReflectionClass(Normalizer::class))->getConstants());
array(11) {
  ["NONE"]=>
  int(2)
  ["FORM_D"]=>
  int(4)
  ["NFD"]=>
  int(4)
  ["FORM_KD"]=>
  int(8)
  ["NFKD"]=>
  int(8)
  ["FORM_C"]=>
  int(16)
  ["NFC"]=>
  int(16)
  ["FORM_KC"]=>
  int(32)
  ["NFKC"]=>
  int(32)
  ["FORM_KC_CF"]=>
  int(48)
  ["NFKC_CF"]=>
  int(48)
}

Now trying to investigate...

from polyfill.

I got it.

For php < 7.3: https://github.com/php/php-src/blob/782bbe722d90d8743f84da712d709a319699bfd6/ext/intl/normalizer/normalizer.h#L24

For php 7.3: https://github.com/php/php-src/blob/3fa88e0ce0ffd9f63672afe114158a07a0204e21/ext/intl/normalizer/normalizer.h#L22

from polyfill.

I can still reproduce the failures on Debian unstable (PHP 7.3.2-3). I don't know why they don't fail on travis-ci.

from polyfill.

@legoktm , here's my explanation.

• php < 7.3 + any ICU and php >= 7.3 + ICU < 56 work the same way.
• php >= 7.3 + ICU >= 56 works differently, see https://github.com/php/php-src/blob/3fa88e0ce0ffd9f63672afe114158a07a0204e21/ext/intl/normalizer/normalizer.h#L35 (this is why Normalizer constants have different values).

Now if you have php 7.3 and ICU 63 like I do, then tests fail.
Travis does not update icu regularly, see symfony/symfony#14259 and travis-ci/travis-ci#3616. That's why it does not fail on 7.3 yet.

from polyfill.

@nicolas-grekas , let's reopen this issue?
I am ready to try to fix it.

from polyfill.

Sure, thanks!

from polyfill.

@nicolas-grekas , actually PHP: nightly fails (https://travis-ci.org/symfony/polyfill/jobs/490568453) because of the ICU version, because php: nightly builds on travis checkout the latest ICU version (travis-ci/travis-ci#3616 (comment)).

So we now we know the problem and the testing tool! I will continue working on this.

from polyfill.

Ooh, nice find @nicolas-grekas. Thanks for working on this :-)

from polyfill.

@nicolas-grekas , @legoktm , I finally made tests fail. See #171

from polyfill.