Add support for JSON_THROW_ON_ERROR for the PHP 7.3 polyfill about polyfill HOT 8 CLOSED

How would you implement this? Just declaring the constant maybe?

from polyfill.

If the constant is not defined then declare it yeah, or conditionally declare it based on the PHP version.

from polyfill.

The difficulty would be to add this functionality to the json_decode function. As just adding the exception and the constant won't create the same functionality.

from polyfill.

no indeed you would also need to override the json_decode()/json_encode() functions and check for the mode to thrown an error when the option is passed down

from polyfill.

we cannot override functions, as they are already declared.

from polyfill.

damnit, indeed it's not new functions so that won't work :/ Well I'll be closing it then I guess

from polyfill.

Actually this could easily be done using PHP's native "use function"

http://php.net/manual/en/language.namespaces.importing.php

Examples: https://laravel-news.com/php-safe

from polyfill.

@tm1000 it's a new function in a new namespace, it's not a polyfill for the existing native PHP function

from polyfill.