Polyfill for intl-idn about polyfill HOT 9 CLOSED

Thanks @lbassin for the pull request!

from polyfill.

why not :) do you have code?

from polyfill.

why not.
perhaps https://github.com/true/php-punycode ?

from polyfill.

do you have code?

Not yet. And I'm not sure, if I am able to do this. But maybe I will try.

perhaps https://github.com/true/php-punycode ?

I guess we have to re-implement this to be compatible with the original functions.

Should the polyfill support the deprecated variant INTL_IDNA_VARIANT_2003? (I don't think so)

from polyfill.

It's OK to have a partial polyfill, so no, no need to support deprecated features (and if someone comes with a PR later, fine :) )

from polyfill.

This is the php-src part of the functions: https://github.com/php/php-src/blob/master/ext/intl/idn/idn.c
But the main conversion is done by functions uidna_nameToASCII_UTF8 and uidna_nameToUnicodeUTF8 from ICU.

from polyfill.

I guess we have to re-implement this to be compatible with the original functions.

well, they tried to be compatible.

we can cover it with tests, sure, see what's missing
simply, there may be no need to reimplement everything from scratch

from polyfill.

simply, there may be no need to reimplement everything from scratch

Would be very nice!

But:

• If true/php-punycode#22 is correct, currently it uses IDNA2003. But this is deprecated in intl/idn in favor of UTS46 since 7.2 (http://php.net/manual/en/function.idn-to-utf8.php)
• Do we want to support these options?
• Do we want to support the 4th parameter $idna_info?

from polyfill.

See true/php-punycode#28

from polyfill.