Flex tries to inspect vendor/ after Composer has already removed the package about flex HOT 5 CLOSED

Thinking about this issue a bit more, I'm wondering if copying files from a package is really a feature we want to keep.

from flex.

Closing as staled. Please provide a PR ideally if you can.

from flex.

@nicolas-grekas
I would like to reopen this issue to discuss options.

The problem is described in more detail here: #604
Although it seems to me that the root cause is that \Symfony\Flex\Configurator\CopyFromPackageConfigurator::removeFilesFromDir() iterates over files in the package to figure out what to delete from the project. This is probably to make sure Flex doesn't delete files/folders which weren't copied from the package by the recipe in the first place. However, the package no longer exists in /vendor when this code runs.

In short,

1. on composer install the copy-from-package stuff is copied (eg FE assets)
2. on composer remove there's an error and as a result the composer package is removed, but the recipe is still in symfony.lock (bundle.php entry and copy-from-recipe files get removed correctly)

Unless I'm missing something, the copy-from-package functionality is broken at the moment.

@fabpot mentioned in a comment above that this functionality is in question, but 4 years later it's still there, although not fully working, as evidenced by this issue.
IMO it should either be removed or fixed - at the very least removing a package shouldn't result in an error. Maybe instead of the error, there should be a message explaining that files copied from the package have to be removed manually.

I can provide a PR if you think it makes sense to pursue this.

from flex.

Please provide a PR if you can yes!

from flex.

@nicolas-grekas
There you go #847

from flex.