Git Product home page Git Product logo

Comments (5)

JulienItard avatar JulienItard commented on May 17, 2024

Best pratices :
Second, we recommend using $form->isSubmitted() in the if statement for clarity. This isn't technically needed, since isValid() first calls isSubmitted(). But without this, the flow doesn't read well as it looks like the form is always processed (even on the GET request).

from demo.

frag-seb avatar frag-seb commented on May 17, 2024

I think the "isSubmitted" have only legitimation for

if(!isValid() && isSubmitted()) 

If you want to check something.

I'm assuming that it is submitted when it is vaild.

from demo.

xabbuh avatar xabbuh commented on May 17, 2024

As @JulienItard said, the call to isSubmitted() is just made to make the intention more clear. It's perfectly valid to omit this call in your application, but the demo should comply with the best practices described in the documentation.

from demo.

bocharsky-bw avatar bocharsky-bw commented on May 17, 2024

Already closed in #49

from demo.

frag-seb avatar frag-seb commented on May 17, 2024

Yes, it's alreasy. :D

from demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.