Git Product home page Git Product logo

Comments (1)

MilesCranmer avatar MilesCranmer commented on June 11, 2024

Hm, maybe you are right. I'm considering whether I should just change to throwing some sort of DynamicQuantities.DimensionError. What do you think?

The original motivation of using a flag for this is because having to use try; catch can be fairly expensive in Julia: https://discourse.julialang.org/t/performance-of-hasmethod-vs-try-catch-on-methoderror/99827. This approach is inspired by https://github.com/JuliaPreludes/Try.jl

But perhaps my use-case for this is niche, and it would be more useful for larger community to just throw errors. I can definitely see how this style could lead to bugs where you aren't sure where the valid=false is coming from; whereas throwing regular errors would easily highlight the problem. So perhaps it is worth it to just throw an error.

from dynamicquantities.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.