Comments (8)
Agreed - the current structure was to avoid a larger scale hack in 2.4, but ss3 gives some more flexibility with approaching it. I'd probably also add a message to the user when they land on the initial edit screen that workflow is in effect and an action is required, or perhaps highlighting in the site tree somehow
from silverstripe-advancedworkflow.
I take it we should block the publisher from doing any other actions until they have approved or declined the workflow changes?
I noticed that if the publisher continues to make content changes the content waiting for approval just gets overwritten but the Editor still doesn't gain access to edit the content again until the Publisher has selected approve or the like (even though it wont be approved because the publisher has since made changes) - very complicated!
I really think we need to remove the normal actions until the workflow content has been reviewed. Take a look at these mockups https://github.com/silverstripe/silverstripe-design/blob/master/Design/workflow/workflow_actions-14.png
from silverstripe-advancedworkflow.
Not all workflows will block editing (or other actions) though; some workflows might be that Person A needs to provide the initial copy and submits it, then Group B performs some additional editing before submitting to Group C for final publication approval. Workflow actions currently have the concept of allowing editing or not through canEdit extension checks - I'd prefer it keep this model for now.
I do like the transitions-in-a-fly-up menu; one thing to consider though is that some actions may have more than a 'comments' box for that workflow action to have data entered. Not sure how that would be covered other than a specific screen for workflow data entry?
from silverstripe-advancedworkflow.
It would be good to see a few screen shots of these extra fields (like comments) or are they website specific?
From a usability perspective, at the moment the user has no indication of what they should do next including the publisher so I can see it really needs improvement. I don't have a good enough idea of all the user cases involved to be able to make further suggestion except having a waning message at the top of the page and in the actions panel at the bottom without getting stuck right into it.
from silverstripe-advancedworkflow.
If I get a chance I'll put together some screenshots.
Marcus, does the current system allow for workflow comments?
from silverstripe-advancedworkflow.
Marcus, does the current system allow for workflow comments?
Yep, every action instance has a 'Comments' field.
It would be good to see a few screen shots of these extra fields (like comments) or are they website specific?
They're system specific - more to the point, they're customisable from code per action type, so could conceivably have any number of fields for users to enter data into. But agreed, there needs to be some way to say to the user 'hey you need to do something here!'
from silverstripe-advancedworkflow.
I think we should be able to work from some specific designs based on examples back to a reconfigurable system. We're trying to be a bit more proactive in getting designers involved in OSS work, hence shoulder-tapping Paul.
from silverstripe-advancedworkflow.
On a project I'm working on at the moment, we have relabelled the "Update workflow" button with whatever action the workflow is currently paused on, ie "Request pubication". It makes it much easier for users to know at which step of the workflow they are on, without having to go to the workflow tab.
from silverstripe-advancedworkflow.
Related Issues (20)
- advancedworkflow.js breaks if Workflow actions are not on page in CMS HOT 1
- ...references nonexistent WorkflowApplicable in 'extensions' HOT 2
- ImportForm not rendered HOT 4
- Layout in the "Restrict to Users" section in Workflow definition is broken HOT 2
- Creating a new workflow definition without title throws 500 HOT 2
- Pending approval read-only view broken for content block page
- CMS preview actions nav broken
- Publishing schedule workflow breaks for the draft page if I click on the "Save" button first and then click on the "Apply for approval" button
- Restrict to Users / Groups in Workflow Definition not working HOT 1
- Broken Build - 5.4.x-dev - PHPCS
- Scheduled Publishing Job (WorkflowPublishTargetJob) results in broken job HOT 1
- Save changes on Workflow-Step results in layout-broken landing-page
- Modal formatting is slightly broken with silverstripe/admin 4.12
- silverstripe/versioned 1.13.0 removes deprecated functionality, preventing workflow diff functionality HOT 4
- No end-to-end coverage - need to create behat tests
- Default branch is out of date on several repositories
- Wrong namespace for imports HOT 1
- Incorrect argument order in WorkflowApplicable extension HOT 6
- Too many unwanted icons visible in workflow manage interface HOT 1
- Set up a Workflow without Notification Email HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-advancedworkflow.