Extract repository methods to traits about adminordercreationplugin HOT 3 CLOSED

...and it would solve problem with having the same overwritten repository class in another plugin, now when you have 2 plugins that has their own methods for example in CustomerRepository you cant use both plugins. In AdminOrderCreationPlugin case it's easy to hack it with not importing its config (@SyliusAdminOrderCreationPlugin/Resources/config/app/config.yml) but writing it by hand and putting the same methods in application custom repo because it used only in Resources/config/app/ajax.yml without any injection. But it would be good practice for all plugins not only this one. wdyt?

from adminordercreationplugin.

I will make PR now

from adminordercreationplugin.

@Zales0123, I would say this is bug. As it break things once any other plugin that extends CustomerRepository or ProductVariantRepository come into place:

Argument X passed to SecondPlugin\X::__construct() must be an instance of 
SecondPlugin\Repository\ProductVariantRepositoryInterface, instance of 
Sylius\AdminOrderCreationPlugin\Doctrine\ORM\ProductVariantRepository given ...

from adminordercreationplugin.