Git Product home page Git Product logo

Comments (4)

wainola avatar wainola commented on July 20, 2024

This issue is going to be resolved once Nikola's issue regarding colors examples is finished. Colors example was failing because it had hardcoded the address of the colors contract, relaying on the fact that was present in the local setup. Once the blocker issue is resolve, we can fix this by updating the address over the two examples

from sygma-sdk.

wainola avatar wainola commented on July 20, 2024

this issue is going to be solve doing the following:

  • current examples are using outdated function to create the deposit data. We need to use the latest one
  • examples need to use latest version on sygma-contract and sdk
  • we should remove calling setAdminResource from the script that's deploying the colors contract

Futher improvements:

  • update readme with instructions and explanations.
  • comment the code of the example

from sygma-sdk.

wainola avatar wainola commented on July 20, 2024

Update: the PR for this issue is currently stale. Majority of the comments had been addressed execept for two regarding not using any annotation. There is an issue with the usage of the internal dependency of the monorepo that throws error when trying to run the example. We need to debug this as this is affecting all the examples.

What I proposed here is to merge the current PR, since colors examples are using latest methods referencing current version of permissionless generic handler inside the SDK and create another issue or issues to address the problems with all the examples that are not working properly.

from sygma-sdk.

mpetrun5 avatar mpetrun5 commented on July 20, 2024

Will be revisited after the generic message passing update to the SDK

from sygma-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.