Git Product home page Git Product logo

Comments (4)

KixAss avatar KixAss commented on June 12, 2024 1

@rvdbijl You can fix it by changing 2 lines in climate.py:

Line 988:
return target_temp >= (self._cur_temp + (0 if self._is_heter_active else self._cold_tolerance))

Line 993:
return self._cur_temp >= (target_temp + (0 if self._is_cooler_active else self._hot_tolerance))

from ha-dual-smart-thermostat.

KixAss avatar KixAss commented on June 12, 2024

Same issue here.

from ha-dual-smart-thermostat.

swingerman avatar swingerman commented on June 12, 2024

Could you guys please post your configuration here? I cannot reproduce the problem

from ha-dual-smart-thermostat.

micksam7 avatar micksam7 commented on June 12, 2024

Same problem here. This seems to only occur when in dual Heat/Cool mode. In normal Heat or normal Cool mode, it behaves as expected.

climate:
  - platform: dual_smart_thermostat
    name: Adv Basement Heatpump
    heater: input_boolean.basement_heatpump_heat
    cooler: input_boolean.basement_heatpump_cool
    target_sensor: sensor.average_basement_temperature
    target_temp: 70
    target_temp_high: 71
    target_temp_low: 69
    cold_tolerance: .5
    hot_tolerance: .5
    min_cycle_duration:
      seconds: 60
    keep_alive:
      minutes: 3
    precision: 0.1

image

Changing the climate.py lines as referenced in KixAss's comment partly fixes, but heats/cools only to the set point instead of using the upper/lower tolerances.

A proper fix may be changing _async_control_heat_cool:
from

            too_cold = self._is_too_cold("_target_temp_low")
            too_hot = self._is_too_hot("_target_temp_high")

to

            too_cold = self._is_too_cold("_target_temp_low")
            # keep heater on until set point
            if self._is_heter_active and not self._is_too_hot("_target_temp_low"):
                too_cold = True

            too_hot = self._is_too_hot("_target_temp_high")
            # keep cooler on until set point
            if self._is_cooler_active and not self._is_too_cold("_target_temp_high"):
                too_hot = True

or perhaps changing the logic of async_heater_cooler_toggle

from ha-dual-smart-thermostat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.