Comments (4)
Same question, I read the technique.py in pyattck package and I found out something strange.
temp_list = phase['phase_name']
in def tactic(self, obj),line71 caused every technique reflected only one tactic rather than a list of tactic, which is incorrect.
from pyattck.
With the question I mentioned above, the function '@Property def tactic(self)' also has a bug.
Attention line 50 to line 52
cause self._tactic return a list.Then ,you can't compare a 'str(list).lower()' with a 'str().lower()'
It won't cause fault when a technique only belong to one tactic.But when a technique belong to several
tactics ,it will cause problem.
So to fix it ,you should traversal each tactic that self got, and then compare the each str(tactic).lower with str(item['x_mitre_shortname']).lower()
Here is my code:
from pyattck.
@tlhendri & @skyWalker1997 Can you please create an issue for each of these and I will make the appropriate changes. Reading through this it looks like there are 3 or 4 issues here it would be easier to resolve each in their own individual issues.
I will be begin looking at these. Thanks for bringing them up!
from pyattck.
This should be fixed - pushing to pypi soon
from pyattck.
Related Issues (20)
- is_url almost always returns true so can't load JSON from disk HOT 4
- Mitigations lack a Mitre Att&CK ID HOT 2
- TypeError: 'NoneType' object is not callable for basic example HOT 8
- pre-ATT&CK is deprecated
- How do we query an IP to get its relevant APT data
- Lack of Procedures description HOT 1
- Error when trying to iterate through techniques HOT 1
- JSONDecodeError: Expecting value: line 1 column 1808074 (char 1808073) HOT 2
- TypeError: __init__() missing 2 required positional arguments: 'id' and 'type' HOT 4
- Support v13 of Enterprise ATT&CK
- Key Error when Iterating v12_attack.enterprise.techniques
- Error when using Attck object HOT 2
- Error when trying to iterate through techniques HOT 2
- Bug in version 7.1.2
- Setting up local data files HOT 1
- get_by_tech_id and fuzzy match for context
- Forced root logger and hardcoded logging path HOT 1
- JSON error HOT 3
- Some techniques are missing HOT 1
- Dependencies are too constrained
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyattck.