Now, most of test cases that depends on StdlibUnittest fails due to same error. <p

Progress report I developed a WebAssembly debugger <a href="https

Fix `indirect call type mismatch` about swift HOT 1 CLOSED

swiftwasm commented on July 16, 2024 2

Fix `indirect call type mismatch`

from swift.

Comments (1)

kateinoigakukun commented on July 16, 2024 2

Progress report

I developed a WebAssembly debugger kateinoigakukun/wasminspect. If you are interested in fixing test cases, this tool is very useful to investigate.

As far as I investigated, CapturePropagation pass in SILOptimizer omits partial_apply which is emitted for thunk function call.

For example,

sil @main : $@convention(c) (Builtin.Int32, Builtin.RawPointer) -> Builtin.Int32 {
bb0(%c : $Builtin.Int32, %v : $Builtin.RawPointer):
  // function_ref createInstance()
  %1 = function_ref @$s5Katei14createInstanceAA1SVSgyF : $@convention(thin) () -> Optional<S> // user: %3
  // function_ref thunk for @escaping @convention(thin) () -> (@unowned S?)
  %2 = function_ref @$s5Katei1SVSgIetd_ADIegd_TR : $@convention(thin) (@convention(thin) () -> Optional<S>) -> Optional<S> // user: %3
  %3 = partial_apply [callee_guaranteed] [on_stack] %2(%1) : $@convention(thin) (@convention(thin) () -> Optional<S>) -> Optional<S> // users: %5, %9
}

this SIL is optimized to be that.

sil @main : $@convention(c) (Builtin.Int32, Builtin.RawPointer) -> Builtin.Int32 {
bb0(%c : $Builtin.Int32, %v : $Builtin.RawPointer):
  // function_ref specialized thunk for @callee_guaranteed () -> (@unowned S?)
  %1 = function_ref @$s5Katei1SVSgIgd_ADIegr_TR69$s5Katei1SVSgIetd_ADIegd_TR33$s5Katei14createInstanceAA1SVSgyFTf3pf_nTf3npf_n : $@convention(thin) @noescape () -> @out Optional<S> // user: %2
  %2 = thin_to_thick_function %3 : $@convention(thin) @noescape () -> @out Optional<S> to $@noescape @callee_guaranteed () -> @out Optional<S>
}


// specialized thunk for @callee_guaranteed () -> (@unowned S?)
sil shared [transparent] [reabstraction_thunk] @$s5Katei1SVSgIgd_ADIegr_TR69$s5Katei1SVSgIetd_ADIegd_TR33$s5Katei14createInstanceAA1SVSgyFTf3pf_nTf3npf_n : $@convention(thin) @noescape () -> @out Optional<S> {
// %0                                             // user: %5
bb0(%0 : $*Optional<S>):
  // function_ref createInstance()
  %1 =  function_ref @$s5Katei14createInstanceAA1SVSgyF : $@convention(thin) () -> Optional<S> // user: %3
  %2 = apply %1() : $@convention(method) () -> S // user: %3
  %3 = enum $Optional<S>, #Optional.some!enumelt.1, %2 : $S // user: %4
  store %3 to %0 : $*Optional<S>                  // id: %4
  %5 = tuple ()                                   // user: %6
  return %5 : $()                                 // id: %6
} // end sil function '$s5Katei1SVSgIgd_ADIegr_TR69$s5Katei1SVSgIetd_ADIegd_TR33$s5Katei14createInstanceAA1SVSgyFTf3pf_nTf3npf_n'