Upstream all the changes 🙌 about swift HOT 6 CLOSED

Closing as all of the major patches are now upstreamed.

from swift.

WRT the debugger tuning issue, it's possible this upstream patch might fix it: https://reviews.llvm.org/rG2504f14a06872f2e1755a88b3aab7e6bc280bec7

from swift.

how many of these tasks are critical for things to "just work"

A lot of the things already work pretty well in our fork, or do you have some specific criteria for "just work" here?

Or is this essentially a list of places where the SwiftWasm fork differs from the Apple repo, meaning the SwiftWasm fork has to be maintained separately until they are merged?

Yes, that's the primary purpose of this issue. We have an "umbrella" apple#24684 PR, which stays open as an easy way to see the toolchain diff. There's no plan to merge or push that PR as is, we're only taking small chunks from it and submit as separate PRs upstream, and those get added to the list here. Important to note that not everything from that diff has a corresponding upstream PR yet.

from swift.

That upstream patch did not come through. I'd appreciate it if anyone reading this pushed it forward 🙏 I'm not an expert in that area myself.

from swift.

@MaxDesiatov do you mean the debugging thing? I don’t know why the LLVM review thing says “audit required”, but it appears that it did land: apple/llvm-project@2504f14

Also, I don’t think we need to set the thread mode any more. LLVM will lower atomic operations to regular loads/stores by itself: https://reviews.llvm.org/D58742

So that patch can just be dropped entirely, I think.

from swift.

FYI [LLVM] Support single-floating-point immediate value https://reviews.llvm.org/D77384. Status: been waiting for review for a month. has landed. Looks like that's the only one in the list that hasn't been updated yet.

Maybe this is the wrong place to ask but how many of these tasks are critical for things to "just work" in SwiftWASM? As someone unfamiliar with the requirements of getting feature parity I find it hard to know which of the unmerged pieces need merging, and as such what is the most important / urgent subtask here. Or is this essentially a list of places where the SwiftWasm fork differs from the Apple repo, meaning the SwiftWasm fork has to be maintained separately until they are merged?

from swift.