Git Product home page Git Product logo

Comments (5)

AliSoftware avatar AliSoftware commented on June 12, 2024

Will we need a submodule pointing to SwiftGen/templates here?

Maybe not, as all the tests will do in this repo is test Stencil nodes and filters so those tests can be even more fine-grained and use some JSON as input fixtures to test each node.

OTOH testing on actual data like strings, even though it would more be liked integration tests than unit tests, could be interesting as wellโ€ฆ

from stencilswiftkit.

djbe avatar djbe commented on June 12, 2024

No, the templates submodule is used in SwiftGenKit (for fixtures) and SwiftGen itself (for templates and fixtures).

from stencilswiftkit.

AliSoftware avatar AliSoftware commented on June 12, 2024

Yeah makes sense that tests for StencilSwiftKit we shouldn't rely on templates and resource fixtures anyway, as this repo is supposed to be used by things other than SwiftGen anyway (Sourcery in particular) and some nodes and filters might even move to Stencil proper in the future so tests need to be independent ๐Ÿ‘

from stencilswiftkit.

djbe avatar djbe commented on June 12, 2024

Jup. Concerning more granular tests, we could add some basic tests for:

  • call/macro nodes
  • set node

using bare-bones templates. I'd also split up the strings tests over multiple files, and maybe move the common input strings into 1 constants file.

from stencilswiftkit.

AliSoftware avatar AliSoftware commented on June 12, 2024

Yeah, seems fair. Especially now that we'll have dedicated repos, it's the best time to make more organised tests, more separated and split in multiple files if needed.

from stencilswiftkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.