OAS 3.0 - Use OAS 3.0 annotations instead of old Swagger 1.5.x / OAS 2.x ones (@Api / @ApiXxx) about swagger-codegen-generators HOT 8 CLOSED

It totally makes sense to me.

from swagger-codegen-generators.

@reta Hi! Yup, that makes perfect sense. Of course it would mean using all 2.x annotations and not just @Schema but the idea itself is right.

from swagger-codegen-generators.

Thank you guys, on it.

from swagger-codegen-generators.

@webron @HugoMario I started the work on this issue, the scope is larger then I initially expected, I opened #101 (work-in-progress) so you guys could see the progress and guide me through.

As I have got to know the code a bit more, my understanding is that Swagger Codegen Generators module deals with OAS 3.0.x specification only (not the old 2.x one), so I made the changes non-conditional and always use OAS 3.0.x annotations for code generation. Please correct me if I am wrong here.

from swagger-codegen-generators.

Hello @reta , sorry for delay answer, i wasn't around these last days.

I think your approach is correct and PR LGTM, but i think we need to add an option that let users keep on using the previous annotation. I can help with that.

So the idea is having by default the OAS 3 annotation but leaving an option to anybody that want to keep using the previous one. Let me know if you are done with changes here and i'll file a new ticket for that.

Thanks!

from swagger-codegen-generators.

Hey @HugoMario,

Thanks for looking! Yeah, it would be a bit of work / conditionals, but makes sense overall, will be working on updating the PR to have both specs supported.

Thanks!

from swagger-codegen-generators.

Hey @reta
It sounds great, also if you check this guide https://github.com/swagger-api/swagger-codegen/wiki/How-to-add-an-option-to-a-specific-language-or-framework it would give you an idea. I think it can help us with this feature.

from swagger-codegen-generators.

this has been implemented, so let's close it

from swagger-codegen-generators.