Add Scala support with akka-http server and client about swagger-codegen-generators HOT 24 OPEN

hello @rbiersbach , for OAS 3.0 we're working on https://github.com/swagger-api/swagger-codegen-generators repo. Pleae, let me know if you have any doubt/question, you can reach me on https://gitter.im/swagger-api/swagger-codegen

from swagger-codegen-generators.

no, this is not a duplicated issue and languages implementations for codegen 3.0.0 are always welcome

from swagger-codegen-generators.

Do you need something from the existing scala Codegen? I could migrate them in this repo if you agree to have a look at the generated scala code (after migration). This might give you a basis that you can extend.

from swagger-codegen-generators.

from swagger-codegen-generators.

This is great news!

When I copy the Codegen, I go through these steps:
https://github.com/swagger-api/swagger-codegen/wiki/Swagger-Codegen-migration-(swagger-codegen-generators-repository)

For example it would be great to have all the scala stuff in the io.swagger.codegen.languages.scala package. => io.swagger.codegen.languages.scala.AbstractScalaCodegen and so on.

EDIT: I have noticed you know already that page. I just added 3 small sections:

• Top level class
• Naming convention
• Remove fields declaration hiding another field or variable

from swagger-codegen-generators.

I can give you an other input for the Mustache to Handlebars conversion:

I try to keep this wiki page up to date: Swagger Codegen migration from Mustache and Handlebars templates.

If you are interested, I have created this class to help with the template migration: ConvertMustache.java. It is really raw and basic, but it does the job. Feedback is welcomed.

from swagger-codegen-generators.

from swagger-codegen-generators.

@jmini - Thanks for all the pointers. I have a question: would it be acceptable to develop this in my own repository (not a fork) and use Service Locator to let swagger-codegen access it? I would like to retain IP rights. It would be licensed with Apache 2.0 license, same as this project.

from swagger-codegen-generators.

@reid-spencer it's an open source project, you can do whatever you want (within the license limitations).

from swagger-codegen-generators.

@webron - While that is true, the owners have commit and PR approval privilege that I do not have. If there's a policy that says "no external libraries" or other IP concerns that will prevent my changes from being accepted, I want to know about it sooner rather than later. But, sounds like that's not the case. So, onward I will go. Thanks for the feedback.

from swagger-codegen-generators.

Right, not everyone has write access, for understandable reasons. We process PRs regularly and try to make the best decision based on the community and project needs. Not really sure what you mean by "no external libraries" in this case, so difficult to respond to that.

from swagger-codegen-generators.

I have a question: would it be acceptable to develop this in my own repository (not a fork) and use Service Locator to let swagger-codegen access it

The advantage of having a generator in the common project swagger-codegen-generators is that it will be available in the official distribution. It will be more visible to the community and you will get more feedback.
This has also a cost: you need to communicate with the project. You need to wait for feedback and for review. You also need to accept some choices that were already made by the existing team. If you want to change something, you will need to convince the team.

If you develop something separated, you are on your own and probably more flexible. For the user of your lib: for maven-plugin usage, the users will need to add your lib as plugin dependency. For cli usage they will need to add your jar (and its dependencies) on the classpath.

from swagger-codegen-generators.

@jmini - Perhaps. I plan to modify swagger-codegen-generators and swagger-codegen just enough so that it all functions like the others. It's just that the templates and the actual CodegenConfig class is in another open source jar file that is added to swagger-codegen-generators dependencies like any other. Would that be okay?

from swagger-codegen-generators.

I am not part of the team, I do not decide.

But I can give you my opinion:
I do not think that it is the idea to add an additional dependency to swagger-codegen-generators. If you have a jar containing a CodegenConfig and the templates, it can be used in addition to swagger-codegen-generators or as replacement if you do not care about the generators provided there. You will use it in the maven plugin or in the cli jar.

from swagger-codegen-generators.

Just wondering what the latest is on this.
I can try to help out if needed. I need this for my work.

from swagger-codegen-generators.

Hi guys,
I am thinking about implementing the akka http server generator for 3.0.0 too.
@sean-kim-zocdoc @reid-spencer Did u already start with implementing and are u still interested?
I would like to cooperate on this because it is my first code generator project.

from swagger-codegen-generators.

@rbiersbach I was planning on getting to this around late September so if you can get this started now, that would be great!

from swagger-codegen-generators.

from swagger-codegen-generators.

Ok guess I will start implementing the server generator for akka http now.
@HugoMario Which branch/tag would be the best starting point for Open API 3.0?

from swagger-codegen-generators.

Just to keep u guys up to date:
Work is done on the https://github.com/swagger-api/swagger-codegen-generators/tree/scala-generators
branch

from swagger-codegen-generators.

A first version of the akka http server codegen has been merged to the master.
Basic functionality is covered, but a lot of work is still open.
If you want to help developing please contact me. I got some test code, that didn't fit the repo and will help alot.
Not implemented yet are:

• cookie paramameters due to a bug in the CodegenOperation not providing any cookie params
• security
• generation of unit test stubs
• complex form data
  Also I am sure a lot of topics are open, that I did not think of.

from swagger-codegen-generators.

Hello, what is the status of this issue?
I updated the akka-scala client generator to migrate from spray to akka http, updating the versions of the libs, but I didn't see this issue before doing it.
Is this already done or not? I did this because it could be useful for us in the future, if it can be useful for you, my code is available here https://github.com/joelvim/swagger-codegen/tree/update-akka-scala.
May I open a PR or is it useless?
Best regards

from swagger-codegen-generators.

I only did work for the server generator, so I guess work for the client is welcome :)

from swagger-codegen-generators.

Ok, I opened the PR, let me know if it's ok or if I should change some things.

from swagger-codegen-generators.