Comments (3)
Yes, the results are reported after correcting both the evaluation script and the test leakage problem. Thanks for pointing that out. We might have missed that in the version which we made publicly available.
from kg-reeval.
Thank you for your reply. Based on the "they shouldn't use valid_triples_dict (all triples in train, dev, and test) in this line, but should only use training data" you mentioned in other issues, can I understand that it is enough to change the "self.valid_triples_dict = {j: i for i, j in enumerate(self.train_triples + self.validation_triples + self.test_triples)}" in the code to "self.valid_triples_dict = {j: i for i, j in enumerate(self.train_triples )}"?
There is another problem. I noticed that you have commented out two lines of code in "main.py". In our experiment, this operation will cause loss to fail to converge. Is it possible that you sort out the omissions of the code or should you really comment it out? If it should be commented out, can you tell me why? Thank you.
#main.py
line198 # loss.backward()
line199 # optimizer.step()
from kg-reeval.
Thanks for pointing that out. I have updated the code, please have a look.
from kg-reeval.
Related Issues (13)
- Unable to train ConvE on Fb15k-237 HOT 1
- confused about figure3 in paper HOT 1
- KBAT's hyper-parameter for each dataset HOT 1
- KBAT run error HOT 1
- KBAT:when i run your code , Iteration_loss show "nan". do you know what problem with it? HOT 1
- RotatE: local variable 'positive_arg' referenced before assignment HOT 2
- Unable to train ConvE on Fb15k-237 HOT 1
- can not find the file
- About KBGAT and RGHAT
- hi, want to know what's KGAT 's leakage problem HOT 4
- KBAT数据泄露 HOT 2
- Question about RotatE new evaluation. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kg-reeval.