Comments (8)
Replicated for small as well as large and extra-large...
from svgedit.
Note, that "Small" is now the default value, so any time you open the editor, rulers are off. The only icon size that produces correct rulers positioning is "Medium". For anyone looking for a workaround, go to the SVG-Edit -> Editor Options and change "Icon size" from "Small" to "Medium".
Also, here is a screenshot of the bug for reference:
https://unpkg.com/[email protected]/editor/svg-editor.html
from svgedit.
Related issue: Icon bugs on non-medium icon sizes from 2010
I believe all these bugs have been fixed in r1488.
Love resolution comments starting with "I believe ..." =-D
Commit: 9d08f8c (God bless the VCS)
from svgedit.
And here is the issue in which resizable icons were introduced: Resizable icons (using SVG icons)
Commits:
- c546737 - Made editor preferences (language, icon size and background) be saved and re-applied on page load
- 2a46a5e - Adding SVG icons to svg-editor.html and related scripts, keeping old with -classic suffix
- 78bd230 - Made SVG-icons toolbar resizing more efficient, added new size option
- 20d7b92 - Added more SVG icons, added experimental option to change icon size, fixed clone offset on zoom
Looks like most open source developers who understand SVG are eventually consumed by Adobe...
from svgedit.
Oh well, I guess I'll just uncomment this in my svgedit-config.es.js
:
svgEditor.setConfig({
iconsize: 'm', // Will default to 's' if the window height is smaller than the minimum height and 'm' otherwise
}
Curiously enough, the comment says that it only defaults to 's'
if window height is small. Apparently my 1080p screen is "small"...
from svgedit.
Note that the comment says "If the window height is smaller than the minimum height".
The code which determines this is this following portion of svg-editor.js
:
const tleft = $('#tools_left');
let minHeight;
if (tleft.length) {
minHeight = tleft.offset().top + tleft.outerHeight();
}
const size = editor.pref('iconsize');
editor.setIconSize(size || ($(window).height() < minHeight ? 's' : 'm'));
IIRC, we may have changed (more recently) to a small icon size because medium icons had its own problems.
Would be really nice if we had people adding to our tests for against the nice and shiny Cypress UI + Cypress UI code coverage plugin testing framework, as we could really prevent a lot of the regressions which otherwise inevitably happen, particularly when other developers come on board.
from svgedit.
That comment could probably be better worded though to indicate the minimum height is one based on the toolbar.
Also, it seems the code above may explain the reason we changed to small; that the toolbar was ending up too large for some screens. Let us know if you find some flaws in this.
from svgedit.
V7 has a fixed icon size.
from svgedit.
Related Issues (20)
- Nurse christmas
- I would like to hide the tooltip when mouse hover on the layer HOT 8
- One page can not display mulit-Editor
- Indices not displaying correctly
- Can I set the origin of the coordinate system to the bottom left HOT 1
- Font-size Property Restriction: No Support for 'pt' Units HOT 1
- Line not visible in web editor? HOT 2
- [Feature request] Set "fill" and "stroke" opacity independently HOT 1
- Imported svg can't be ungrouped HOT 1
- Multiple jPicker-table in Linear Gradient color picker
- [Edition] Text Edition Bug.
- Embeded image does not show up when import to SVG Edit due to xlink:href not supported anymore.
- Lack of instructions for installing HOT 4
- Clipping Mask HOT 1
- npm run build --workspace @svgedit/svgcanvas failed HOT 3
- ImportSVG and save, re_open the svg , the use size not right HOT 6
- when I use loadFromString , but the Canvas is empty HOT 2
- use element position error HOT 4
- References to deprecated punycode
- fix not show/hide layers ICON HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svgedit.