Comments (7)
Yeah, that'd be a good effort.
from miniserve.
Just one quick question, do you mind having an enum with all miniserve's error kind, or do you want them to be split like right now, aka CompressionErrorKind
, UploadErrorKind
, etc ? In the latter case, I think I need to implement Fail
, Display
, etc, for all those enums, so some copy/paste. Having a single enum allows to implement it once for good, but that's 1 quite big enum. Your call :)
PS: there might be a third solution, that would allow to have separate enums, but only 1 implementation, but sadly I can't figure out how...
from miniserve.
Ok so honestly I'm thinking hard about both ways and I think I'm entirely balanced concerning my opinion on the matter. For one, it seems nice to have separate errors for separate parts of the application but then again we might also run into scenarios where an error fits into neither category and that'd be awkward.
Cutting down on boilerplate is always nice, of course.
I'll let you make the call on this.
from miniserve.
The argument about an error fitting into no/several categories is very true, didn't think about that. This will probably be the case with IoError
, which can happen during compressing, and during uploading.
from miniserve.
from miniserve.
Glad to hear you like it!
from miniserve.
Leaving this open until the very last unwrap()
is gone :P
from miniserve.
Related Issues (20)
- Can the compilation target i686-pc-windows-msvc be added to run on a 32-bit Windows? HOT 15
- Panic when serving non-existent file in SPA mode HOT 1
- support setting permission?
- (systemd) error: unexpected argument ' ' found
- panicked at 'modification time must be after epoch: SystemTimeError(28800s)' HOT 6
- Unable to serve files with embedded newline HOT 2
- hope to add ignore file/dir list parameter HOT 1
- Failed test bind_ipv4_ipv6::case_2 HOT 2
- Does it support hiding some files? HOT 6
- Can't Upload HOT 1
- Add cli flag to disable indexing HOT 1
- Not working with reverse proxy in specific directory HOT 2
- Wget footers : hostname:port is repeated
- Feature request: custom subtitle
- rendering markdown files? HOT 6
- Set upload size limit HOT 2
- Save uploaded file atomically HOT 2
- 上传onedrive问题 HOT 4
- How to use HTTPS HOT 1
- Add Support for HSTS to Enhance HTTPS Security HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniserve.