Git Product home page Git Product logo

Comments (3)

sveetch avatar sveetch commented on August 23, 2024

Ok this is confirmed

from crispy-forms-foundation.

manuphatak avatar manuphatak commented on August 23, 2024

What's happening:
crispy_forms_foundation is setting the styles as class variables:

class Button(crispy_forms_layout.Button):  # buttons.py 90
    input_type = 'button'
    field_classes = 'button'

then crispy_forms is saying thanks, but no thanks, with its hard-coded, un-subclassable Button class:

class Button(BaseInput):  # crispy_forms/layout.py
    input_type = 'button'
    def __init__(self, *args, **kwargs):
        self.field_classes = 'button' if get_template_pack() == 'uni_form' else 'btn no-thank-you'
        super(Button, self).__init__(*args, **kwargs)

I think the solution is to subclass crispy_forms_layout.BaseInput directly insead of crispy_forms_layout.Button.

from crispy-forms-foundation.

sveetch avatar sveetch commented on August 23, 2024

Nice, it make sense, i have to see why i inherited from Button, maybe an old stupid choice.

from crispy-forms-foundation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.