Comments (3)
Hey @rytswd , could you perhaps provide an example of how you think this could work? Do you have example data structures? Is this about ordering of keys? Does slice work for Unmarshal instead of SmartUnmarshal?
from surrealdb.go.
Hi @phughk! Sure, for the data structure, do you mean what return type we should use? In my code in the PR, I simply defined a new func SmartUnmarshalAll[T]
to return []T
instead of T
. (I also added a note how one could call with slice type such as SmartUnmarshal[[]User]( ... )
, but this looks quite foreign to me...)
For the example, I actually shared my finding in a comment in the above PR:
data, err = db.Query(`
CREATE user:j SET name = "J";
CREATE user:j SET name = "J"; // conflict
CREATE user SET name = "John";
`, nil)
if err != nil {
t.Fatal(err) // Not hit
}
y, err := surrealdb.SmartUnmarshal[[]User](data, nil)
t.Logf("old data: %+v", y) // old data: [{Username: Password: ID:user:j Name:J}]
t.Logf("old err: %+v", err) // old err: <nil>
x, err := surrealdb.SmartUnmarshalAll[User](data)
t.Logf("new data: %+v", x) // new data: [{Username: Password: ID:user:j Name:J} {Username: Password: ID:user:3owq0tv8kn0aiz1rc6od Name:John}]
t.Logf("new err: %+v", err) // new err: ERR: Database record `user:j` already exists
Because the RawQuery
can be nested, the generic handling needs to handle RawQuery
as any
type, and recursively unmarshal. This could potentially cause degraded performance, and Unmarshal
may be a better fit. But as there is already SmartUnmarshal
in place, I'd think it should at least treat the errors and data write path fully.
It is arguable what the idiomatic Go implementation should look like with generics, but having to specify []User
rather than User
for the type input seems unnatural to me.
This is potentially an area where godoc clarification may be sufficient, as long as the SmartUnmarshal
can handle bulk input with full details of all items written and any errors hit.
Hope this makes sense, and if there is any more clarifications needed, I'd be happy to share!
from surrealdb.go.
It's definitely a good idea, but I am wondering if we would rather use Row and Column from the upcoming changes? It might result in a simpler solution to use, and reduce the number of options for deserialising
from surrealdb.go.
Related Issues (20)
- Feature: context.Context Support HOT 6
- Documentation: working with record links HOT 4
- Feature: Move and test `unmarshalMapToStruct(data map[string]interface{}, outStruct interface{})` HOT 2
- Bug: Re-connection to the DB HOT 2
- Bug: Broken Tests for Fetch HOT 5
- Bug: Unhandled errors in websockets can lead to panics HOT 4
- Bug: `Question or idea` Button HOT 2
- surrealdb Auth undefined HOT 1
- Bug: unexpected EOF on TestSurrealDBSuite/gorilla/TestUpdate HOT 1
- Documentation: The README file example is not usable with the latest main branch, neither with the latest version HOT 1
- Feature: Replace Gorilla WS with Nhooyr WS HOT 7
- Bug: The session has expired error when connecting to version 1.3.0 HOT 4
- Bug: stack overflow error in gorilla websocket with db version 1.3.0 HOT 4
- Feature: surrealML for golang
- Documentation: Add Documentation for .Live() func & other stuff related to LIVE queries HOT 6
- Change function does not exist HOT 3
- Feature: Add CBOR support HOT 2
- Feature: better error return HOT 9
- Feature: Formatting Query like fmt.Sprintf HOT 2
- Example fails in Beta 11 - panic: sending request failed for method 'change': Method not found HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from surrealdb.go.