Comments (7)
Huh I was about to add a comment like "do you still see this" but then I realized that I see it too.
However it isn't the pan slider that is missing. It is the "slider below pan".
// pan2 control
if ((synth->storage.getPatch().scene[current_scene].filterblock_configuration.val.i !=
fb_stereo) &&
(synth->storage.getPatch().scene[current_scene].filterblock_configuration.val.i != fb_wide))
{
i = synth->storage.getPatch().scene[current_scene].width.id;
if (param[i] && dynamic_cast<CSurgeSlider*>(param[i]) != nullptr)
((CSurgeSlider*)param[i])->disabled = true;
}
is the code that activates it. So when you set the filter configuration to "wide" it appears, kinda. You need to click to force a repaint. And when you turn off wide it doesn't undisplay.
So the bug here is a bit more subtle. It is that "wide mode on filter doesn't force draw; and disabled wide mode is blank". Ideally you'd make filter->disabled=true not be so disabled!
But more importantly when you toggle wide mode, you want to do a param refresh which forces a createOrRedraw. Something about the setDirty around line 1938 of SurgeGUIEditor isn't enough.
from surge.
Actually @esaruoho can you rename this issue to "Filter Width Pan Slider doesn't invalidate properly" so we know what to fix?
from surge.
@baconpaul i updated the title and will look again so can rewrite the original ticket. Thanks for the sleuthwork!
from surge.
yeah this slider only appear in the wide mode, in the others the signal path is mono up until that point
from surge.
Thanks @kurasu - the invalidation code means it doesn’t immediately toggle on off when you go into and out of wide, so there’s a tiny bug let there somewhere, but we can fix that soon enough I’m sure!
from surge.
I have this invalidation fixed. It's just behind #148. I could cherry pick it over and sweep it but if folks like the logger it is easier to just wait and sweep it then. baconpaul/surge branch width-invalidate-75 is the tiny change needed.
from surge.
Fixed at head; closing.
from surge.
Related Issues (20)
- Update to Juce 7.0.12 (should fix Audio/MIDI settings dialog not opening on Ubuntu) HOT 7
- Loading of a specific Surge configuration results in pathological system instability HOT 12
- Weird echo on Raspberry build with "virtual midi" HOT 4
- Load Vital Presets in Surge? HOT 3
- Release checklist for Surge XT 1.3.3
- Add checksum to all release assets
- surge mute sound after loading preset HOT 4
- Pitch bend messages affect every note, ignoring midi channel match HOT 2
- Quick way to compare currently edited with original patch HOT 4
- Quick way to compare edited patch with original patch HOT 3
- Allow oscillator pitch to be modulated by more than an octave HOT 1
- selecting a preset from favourites should set the category to "favourites" so i can scroll through the patches HOT 1
- Surge UI redesign concept HOT 2
- Looking to fix and bump failing build for Surge 1.7.1 to Surge-XT 1.3.2 on Guix HOT 20
- Context menus don't show up HOT 1
- Parameters automation resolution HOT 3
- Access to midi modulators via Lua(formula) HOT 9
- Open Wavetable standard idea. HOT 3
- Recursive create user path on windows HOT 2
- Pybind: Add ability to process inputs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from surge.