Comments (1)
I suspect that it verified the proxy at the first attempt, but failed with the logic contract and linking.
Our issue here is that there seems to be no way with truffle-plugin-verify to verify only the proxy contract, not the implementation. It tries to be smart and verify the logic the proxy points to. See rkalis/truffle-plugin-verify#178
In this project, we're kind of cheating, because the code of the implementation contract is outside of this project. A more correct cmdline for verification would actually be:
npx truffle run --network goerli verify SuperToken@0xA862f128b3ffE9719948869cc1C7CBC21860Cd9a --custom-proxy BurnMintSuperToken
However we don't have aSuperToken
artifact here.
It probably wouldn't be too difficult to get it (since we have the ethereum-contracts npm package), but even then its bytecode would likely often not match the one currently deployed, because the package version may not match the version of the currently deployed contracts etc.
So, it will fail when trying to verify the implementation contract, but succeed with verifying the proxy contract, which is what we need.
I think it didn't fail in the past if the implementation contract was already verified, but am not sure. Maybe that changed, or maybe it's related to changes in the canonical SuperToken logic contract (it's nomore deployed by the SuperTokenFactory contract in 1.5.2+).
Long story short: I don't currently see an obvious way to properly fix this without making it more fragile.
But there's a pretty simple way to work around it: ignore the error message and manually do the "linking" between proxy and logic in the explorer.
I updated the README accordingly in this PR: https://github.com/superfluid-finance/custom-supertokens/pull/23/files
I didn't do it for 0xA862f128b3ffE9719948869cc1C7CBC21860Cd9a, so you can try it yourself.
Let me know if that's not working as expected or if you have any more questions or suggestions.
And thx for the report!
from custom-supertokens.
Related Issues (18)
- Reuse utils/SuperfluidFrameworkDeployer.sol HOT 1
- Update tests to use Hardhat
- Difficult to verify Supertokens HOT 3
- Upgrade project to use Hardhat
- Align code style
- Observations based on a support session of an implementer
- Adhere to New Super Token Naming Conventions HOT 1
- [CUSTOM-SUPERTOKENS] Use metadata instead of hardcoded factory addresses HOT 2
- [BOUNTY] Super Token Wizard HOT 5
- [SUPER-TOKEN] Make compatible with current ethereum-contracts release
- Continue to explore upgradable SuperToken Custom Logic
- [CUSTOM-SUPER-TOKENS] Support Upgradability of Custom Super Token Logic HOT 1
- Pure Super Token with xERC20 support HOT 5
- Migrate MaticBridgedNativeSuperToken HOT 1
- Add coverage report
- Tests not passing
- Update README to reflect new repo location
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from custom-supertokens.