Trouble Verifying Custom SuperTokens on Goerli about custom-supertokens HOT 1 CLOSED

I suspect that it verified the proxy at the first attempt, but failed with the logic contract and linking.
Our issue here is that there seems to be no way with truffle-plugin-verify to verify only the proxy contract, not the implementation. It tries to be smart and verify the logic the proxy points to. See rkalis/truffle-plugin-verify#178

In this project, we're kind of cheating, because the code of the implementation contract is outside of this project. A more correct cmdline for verification would actually be:

npx truffle run --network goerli verify SuperToken@0xA862f128b3ffE9719948869cc1C7CBC21860Cd9a --custom-proxy BurnMintSuperToken

However we don't have aSuperToken artifact here.
It probably wouldn't be too difficult to get it (since we have the ethereum-contracts npm package), but even then its bytecode would likely often not match the one currently deployed, because the package version may not match the version of the currently deployed contracts etc.

So, it will fail when trying to verify the implementation contract, but succeed with verifying the proxy contract, which is what we need.
I think it didn't fail in the past if the implementation contract was already verified, but am not sure. Maybe that changed, or maybe it's related to changes in the canonical SuperToken logic contract (it's nomore deployed by the SuperTokenFactory contract in 1.5.2+).

Long story short: I don't currently see an obvious way to properly fix this without making it more fragile.
But there's a pretty simple way to work around it: ignore the error message and manually do the "linking" between proxy and logic in the explorer.
I updated the README accordingly in this PR: https://github.com/superfluid-finance/custom-supertokens/pull/23/files

I didn't do it for 0xA862f128b3ffE9719948869cc1C7CBC21860Cd9a, so you can try it yourself.
Let me know if that's not working as expected or if you have any more questions or suggestions.
And thx for the report!

from custom-supertokens.